WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#33597 closed enhancement (fixed)

Use the site icon on the login screen

Reported by: johnbillion Owned by:
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Login and Registration Keywords:
Focuses: multisite Cc:
PR Number:

Description

If a site icon (#16434) is in use on a site, the WordPress logo on wp-login.php should be replaced with the icon.

In addition, its wordpress.org link should be replaced with the home URL, and its 'Powered by WordPress' title attribute should either be removed or replaced with the site title.

This change will need to play nicely with plugins which filter the link and title with login_headerurl and login_headertitle or change the logo with CSS.

Also need to bear in mind behaviour on multisite, which already replaces the link and title with the site's home URL and title. If a site doesn't have a site icon, should the site icon for the primary site on the network be shown?

Attachments (1)

33597.diff (565 bytes) - added by iworks 4 years ago.
Add site icon to login screen.

Download all attachments as: .zip

Change History (11)

#1 @obstschale
4 years ago

Interesting idea. I think that would be nice benefit of the new site icon feature. However you also need to thing about the image size. If the site icon is to small it might look awful on the login site.

#2 @iworks
4 years ago

I know, my patch is not exactly what is in this ticket, but it provide a site_icon as a icon on login screen. I added function wp_site_icon() to login_head action. [Contributor Day WC PL]

@iworks
4 years ago

Add site icon to login screen.

#3 @johnbillion
4 years ago

  • Milestone changed from Awaiting Review to 4.4

#4 @johnbillion
4 years ago

Good spot, iworks.

#5 @johnbillion
4 years ago

In 34124:

Add the site icon meta tags to wp-login.php.

See #33597
Props iworks

#6 follow-ups: @obenland
4 years ago

Site Icon !== Site Logo. We discourage themes from using site icons as logos, I think we should avoid using them as such on the login screen. (Unrelated to [34124] btw).

Maybe I'm being too pedantic about the purpose of Site Icons here, but in my mind they serve in a representative role outside of the context of the site itself, rather than as a logo within that context. Does that make sense?

#7 @wonderboymusic
4 years ago

#33755 was marked as a duplicate.

#8 in reply to: ↑ 6 @fatmedia
4 years ago

Replying to obenland:

Site Icon !== Site Logo. We discourage themes from using site icons as logos, I think we should avoid using them as such on the login screen. (Unrelated to [34124] btw).

Maybe I'm being too pedantic about the purpose of Site Icons here, but in my mind they serve in a representative role outside of the context of the site itself, rather than as a logo within that context. Does that make sense?

+1

#9 @johnbillion
4 years ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

I'm not entirely convinced that using the site icon is not appropriate here, but implementing and using a site logo would be preferable.

Marking as fixed in [34124].

Site logo is handled in #33755.

#10 in reply to: ↑ 6 @benoitchantre
4 years ago

Replying to obenland:

Site Icon !== Site Logo. We discourage themes from using site icons as logos, I think we should avoid using them as such on the login screen. (Unrelated to [34124] btw).

Maybe I'm being too pedantic about the purpose of Site Icons here, but in my mind they serve in a representative role outside of the context of the site itself, rather than as a logo within that context. Does that make sense?

+1

It makes sense. To expand a bit: I think the context changes when the login page is personalized or not.

The default login page uses the WordPress icon. In this context, the image relates to the software that runs your website. When you log in, you enter the the software UI that runs your site.

When you personalize the login page, the image needs to relate to the brand of the website, but outside of the website (ex: home screen of mobile devices, favorites websites in your browser), the icon is a better choice.

Note: See TracTickets for help on using tickets.