WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#33605 closed defect (bug) (fixed)

#a11y-headings - Add New User page headings

Reported by: Cheffheid Owned by: afercia
Priority: normal Milestone: 4.4
Component: Administration Version: 4.3
Severity: normal Keywords: good-first-bug has-patch commit
Cc: Focuses: accessibility

Description

"Add Existing User" (multisite) and "Add New User" headings need to be bumped up from h3 to h2 and have their CSS changed to look like they did before the heading change.

#a11y-headings

Attachments (2)

33605.patch​ (1.0 KB ) - added by Cheffheid 11 years ago.
Heading fix (only appear on multi site installs)
33605.2.patch​ (1.0 KB ) - added by afercia 11 years ago.

Download all attachments as: .zip

Change History (12)

#1 @Cheffheid
11 years ago

  • Keywords good-first-bug added

#2 @mrahmadawais
11 years ago

Isn't it already h1. Where are you talking about?

@Cheffheid
11 years ago

Heading fix (only appear on multi site installs)

#3 @Cheffheid
11 years ago

  • Keywords has-patch added

#4 @SergeyBiryukov
11 years ago

  • Milestone Awaiting Review → 4.4

#5 @SergeyBiryukov
11 years ago

  • Keywords commit added
  • Owner set to afercia
  • Status new → assigned

@afercia
11 years ago

#6 @afercia
11 years ago

Tested and verified, refreshed patch rebuilt from the root.

#7 @afercia
11 years ago

  • Resolution → fixed
  • Status assigned → closed

In 33945:

Bump H3 headings to H2 on the Network Add New User screen for better accessibility.

Props Cheffheid.
Fixes #33605.

#8 @ryan
11 years ago

  • Keywords needs-screenshot added

#9 @ryan
11 years ago

  • Keywords needs-screenshots added; needs-screenshot removed

#10 @ryan
11 years ago

  • Keywords needs-screenshots removed

Momentarily tagged this needs-screenshots to remind me to test for unintended visual hierarchy changes. Watching and testing header changes is a hobby of mine. :-) Looks good, although I didn't exercise all conditionals. Removing tag.

Note: See TracTickets for help on using tickets.