WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#33606 closed defect (bug) (fixed)

#a11y-headings - Your Profile page headings

Reported by: cheffheid's profile Cheffheid Owned by: afercia's profile afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: good-first-bug has-patch commit
Focuses: accessibility Cc:

Description

All H3 headings on this page can be bumped up to H2.

#a11y-headings

Attachments (1)

33606.diff​ (1.7 KB) - added by metodiew 10 years ago.
Your Profile page headings - All H3 headings on this page can be bumped up to H2.

Download all attachments as: .zip

Change History (9)

#1 @Cheffheid
10 years ago

  • Keywords good-first-bug added

#2 follow-up: @metodiew
10 years ago

What about Visual Editor, Nickname (required) and a few other fields which are table headings (<th>) elements?

#3 in reply to: ↑ 2 @afercia
10 years ago

Replying to metodiew:

What about Visual Editor, Nickname (required) and a few other fields which are table headings (<th>) elements?

Those are table headers, not h1-h6 headings :)

@metodiew
10 years ago

Your Profile page headings - All H3 headings on this page can be bumped up to H2.

#4 @metodiew
10 years ago

  • Keywords has-patch added

I wasn't sure if we need to change them too, that's why I asked before submitting the patch. Thanks for the clarification! :)

#5 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to afercia
  • Status changed from new to reviewing

#6 @SergeyBiryukov
10 years ago

  • Keywords commit added

#7 @afercia
10 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 33909:

Accessibility: bump H3 headings to H2 on User Edit and Your Profile screens.

Ongoing effort to restore a good headings hierarchy in the admin screens after the reintroduction of the missing main <h1> in [32974].

Fix a typo in the DocBlock for the additional_capabilities_display filter.

Props metodiew.
Fixes #33606. See #31650.

#8 @afercia
10 years ago

#33661 was marked as a duplicate.

Note: See TracTickets for help on using tickets.