Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#33609 closed defect (bug) (fixed)

#a11y-headings - Discussion Settings page headings

Reported by: cheffheid's profile Cheffheid Owned by: afercia's profile afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: good-first-bug has-patch commit
Focuses: accessibility Cc:

Description

The "Avatars" heading on this page can, and should, be changed from H3 to H2.

#a11y-headings

Attachments (1)

33609.patch (632 bytes) - added by mrahmadawais 9 years ago.
h3 to h2 at options-discussion.php

Download all attachments as: .zip

Change History (14)

#1 @Cheffheid
9 years ago

  • Keywords good-first-bug added

@mrahmadawais
9 years ago

h3 to h2 at options-discussion.php

#2 @mrahmadawais
9 years ago

  • Keywords has-patch needs-testing added

I have added a patch to address this issue.

#3 @SergeyBiryukov
9 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to afercia
  • Status changed from new to reviewing

#4 @SergeyBiryukov
9 years ago

  • Keywords commit added; needs-testing removed

#5 follow-up: @wonderboymusic
9 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 33916:

Bump H3 headings to H2 on the Discussion Settings screen for better accessibility.

Props mrahmadawais.
Fixes #33609.

#6 in reply to: ↑ 5 ; follow-up: @mrahmadawais
9 years ago

Replying to wonderboymusic:

In 33916:

Bump H3 headings to H2 on the Discussion Settings screen for better accessibility.

Props mrahmadawais.
Fixes #33609.

Great!
This will be the part of WP 4.4 ?

#7 in reply to: ↑ 6 @SergeyBiryukov
9 years ago

Replying to mrahmadawais:

This will be the part of WP 4.4 ?

Yes.

#8 follow-up: @ryan
9 years ago

  • Keywords needs-screenshots added

#9 in reply to: ↑ 8 ; follow-up: @mrahmadawais
9 years ago

Replying to ryan:
What screenshots? Ain't it already committed and closed?

#10 in reply to: ↑ 9 ; follow-up: @ryan
9 years ago

Replying to mrahmadawais:

Replying to ryan:
What screenshots? Ain't it already committed and closed?

I do screenshots for visual changes and compile them into the Today in the Nightly visual change log.

#11 in reply to: ↑ 10 ; follow-up: @mrahmadawais
9 years ago

Replying to ryan:

Replying to mrahmadawais:

Replying to ryan:
What screenshots? Ain't it already committed and closed?

I do screenshots for visual changes and compile them into the Today in the Nightly visual change log.

I didn't know that. Can you direct me to such a change-log?

BTW this is not a visual change, it is at the backend, changes nothing visually.

#12 in reply to: ↑ 11 @ryan
9 years ago

  • Keywords needs-screenshots removed

Can you direct me to such a change-log?

https://make.wordpress.org/core/tag/today-in-the-nightly/

BTW this is not a visual change, it is at the backend, changes nothing visually.

Whenever I see a header change, I flag it with needs-screenshots in case visual hierarchy has changed as a result. Visual hierarchy changes are always notable. Looks like h2 and h3 share a style and a font-icon in this case, so you're right indeed that needs-screenshots is not needed.

#13 @mrahmadawais
9 years ago

@ryan Glad I could help.

Note: See TracTickets for help on using tickets.