Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #33620, comment 2


Ignore:
Timestamp:
09/08/2015 12:47:05 PM (11 years ago)
Author:
thomaswm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33620, comment 2

    initial v1  
    22> This is blocked by #33041
    33
    4 I wonder why `install_blog()` calls `get_blogaddress_by_id()` to retrieve the path and domain from the database when they could have just as easily been passed to `install_blog()` as function parameters. They are stored as variables in `wpmu_create_blog()` but they aren't passed on to `install_blog()`.
     4I wonder why `install_blog()` calls `get_blogaddress_by_id()` to retrieve the URL from the database when it could have just as easily been passed to `install_blog()` as a function parameter. The path and domain are stored as variables in `wpmu_create_blog()` but they aren't passed on to `install_blog()`.
    55
    66[https://core.trac.wordpress.org/browser/tags/4.3/src/wp-includes/ms-functions.php#L1161 Line 1161] in `wp-includes/ms-functions.php` would have to be changed to
     
    88
    99{{{
    10 install_blog($blog_id, $title, $scheme, $domain, $path);
     10install_blog($blog_id, $title, $url);
    1111}}}
    1212and then the call to `get_blogaddress_by_id()` would be obsolete.