WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 7 of Ticket #33621


Ignore:
Timestamp:
09/01/2015 11:37:01 PM (9 years ago)
Author:
johnbillion
Comment:

Just realised that I typo'd the field name in the ticket description. siteurl is represented by the "WordPress Address" field, not the "Site Address" field (yay naming).

Replying to peterwilsoncc:

Changing the value on save could confuse the user for no reason, especially if they expect home & site URLs to match.

Why would a user expect the URLs to match if FORCE_SSL_ADMIN is set to true but their home URL uses http? Displaying the incorrect scheme is the confusing behaviour.

Related: [28674]

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #33621 – Description

    initial v7  
    1 When `FORCE_SSL_ADMIN` is defined and set to true, the "Site Address (URL)" option on the General Settings screen still shows an `http` scheme unless the site was installed over `https` or the scheme was manually changed.
     1When `FORCE_SSL_ADMIN` is defined and set to true, the "WordPress Address (URL)" option on the General Settings screen still shows an `http` scheme unless the site was installed over `https` or the scheme was manually changed.
    22
    33The `siteurl` option should either be filtered to show an `https` scheme, or be corrected to have an `https` scheme when the option is saved.