Add Edit link to page template meta box

[sgrant]

This patch adds an edit link beside the Template text on the page editor, similar to the Status/Visibility links. This feature was mentioned as a possibility by @matt in a recent WordCamp Q&A session. I tested this on a number of themes locally, but would love some feedback. Thanks!

[sgrant]

Adds an Edit link for templates in the page editor

[helen]

As much as I am against removing the file editor, I also don't think it's something that we should encourage using past a certain point. Adding a link here in a frequent-use screen by default would IMO imply that this is a suggested action, not just a possible one.

[sgrant]

@helen I definitely see your point. I was hoping to tackle this with a plugin, but there's no hook here. What do you think about adding a filter into the meta box instead?

[helen]

@sgrant What would a general purpose hook here look like and what else could it be used for? Not against adding one, but I am wary of things that might only serve one real purpose. As a hacky way to do this, you can use the gettext filter to "translate" Template into another string (untested though).

[sgrant]

Add a hook after Template on the page editor

[sgrant]

@helen Good and fair question! I guess the only use case I'd thought of immediately was adding the edit link. As precedent, preview_post_link is filtered earlier in meta-boxes.php, and is used in some cases to "repair" a bad preview URL. Although this is different, I suppose general use-cases here might be adding a link to the template file or adding a link to reset to the default template. Do you think this filter might be too speculative?

[wonderboymusic]

Filters need docs

[sgrant]

Add docstring

[sgrant]

Updated the patch--thanks for taking a look!

[SergeyBiryukov]

This should probably be an action instead of a filter.

[sgrant]

Action instead of filter

[sgrant]

Action does seem cleaner, patch attached. Thanks!

[wonderboymusic]

In 34340:

In page_attributes_meta_box(), add an action, 'page_attributes_meta_box_template' to allow callbacks to be performed and HTML to be inserted after the title of the Template section.

Props sgrant.
Fixes #33625.

[DrewAPicture]

In 34349:

Docs: Use standardized vernacular in the hook doc summary for the page_attributes_meta_box_template filter, introduced in [34340].

See #33625.

[DrewAPicture]

+ $post

[DrewAPicture]

Seems like it might be good to also pass the current post here. This is done in 33625.diff​.

[SergeyBiryukov]

In 34350:

Pass the current post object to 'page_attributes_meta_box_template' action added in [34340].

Props DrewAPicture.
Fixes #33625.