WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33630 closed defect (bug) (fixed)

Delete menu - similar strings and HTML

Reported by: pavelevap Owned by: ocean90
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: Menus Keywords:
Focuses: Cc:
PR Number:

Description

  • Menu in Customizer

String: "Delete menu"
HTML: Button
https://core.trac.wordpress.org/browser/tags/4.3/src/wp-includes/class-wp-customize-control.php#L1585

  • Menu page

String: "Delete Menu" (both capital letters)
HTML: Link
https://core.trac.wordpress.org/browser/tags/4.3/src/wp-admin/nav-menus.php#L813

1) I only wanted to merge same strings, but I found other issues.

2) Also HTML should be the same (button)?

3) {{ data.menu_name }} as screen reader text does not print anything.

4) For localization it should be string like Delete menu <span class="screen-reader-text">%s</span>?

Change History (2)

#1 @ocean90
4 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to ocean90
  • Status changed from new to reviewing

#2 @ocean90
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35695:

Customizer: Merge two similar strings.

Remove also {{ data.menu_name }} since it doesn't print anything.

Fixes #33630.

Note: See TracTickets for help on using tickets.