WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33633 closed defect (bug) (fixed)

Menu Customizer: Reorder x Done

Reported by: pavelevap's profile pavelevap Owned by: afercia's profile afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch commit
Focuses: ui Cc:

Description

When I click "Reorder", special mode for reordering items is used. But button should be changed into "Done"? I can see only "Reorder". Widgets panel works fine.

Attachments (1)

33633.patch​ (671 bytes) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (7)

#1 @afercia
9 years ago

  • Component changed from Menus to Customize
  • Focuses ui added
  • Milestone changed from Awaiting Review to 4.4
  • Version changed from trunk to 4.3

After switching from ids to classes in 33604, in the CSS selectors .reordering should be before .customize-control-nav_menu.

@afercia
9 years ago

#2 @afercia
9 years ago

  • Keywords has-patch added

In the proposed patch:

  • Menu Customizer: use correct CSS selectors for the reorder-toggle button after 33604

#3 @SergeyBiryukov
9 years ago

  • Keywords commit added

Looks good.

#4 @SergeyBiryukov
9 years ago

  • Owner set to afercia
  • Status changed from new to assigned

This ticket was mentioned in ​Slack in #core by afercia. ​View the logs.
9 years ago

#6 @afercia
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33856:

Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604].

Fixes #33633.

Note: See TracTickets for help on using tickets.