WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#33633 closed defect (bug) (fixed)

Menu Customizer: Reorder x Done

Reported by: pavelevap Owned by: afercia
Priority: normal Milestone: 4.4
Component: Customize Version: 4.3
Severity: normal Keywords: has-patch commit
Cc: Focuses: ui

Description

When I click "Reorder", special mode for reordering items is used. But button should be changed into "Done"? I can see only "Reorder". Widgets panel works fine.

Attachments (1)

33633.patch​ (671 bytes ) - added by afercia 11 years ago.

Download all attachments as: .zip

Change History (7)

#1 @afercia
11 years ago

  • Component Menus → Customize
  • Focuses ui added
  • Milestone Awaiting Review → 4.4
  • Version trunk → 4.3

After switching from ids to classes in 33604, in the CSS selectors .reordering should be before .customize-control-nav_menu.

@afercia
11 years ago

#2 @afercia
11 years ago

  • Keywords has-patch added

In the proposed patch:

  • Menu Customizer: use correct CSS selectors for the reorder-toggle button after 33604

#3 @SergeyBiryukov
11 years ago

  • Keywords commit added

Looks good.

#4 @SergeyBiryukov
11 years ago

  • Owner set to afercia
  • Status new → assigned

This ticket was mentioned in ​Slack in #core by afercia. ​View the logs.
11 years ago

#6 @afercia
11 years ago

  • Resolution → fixed
  • Status assigned → closed

In 33856:

Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604].

Fixes #33633.

Note: See TracTickets for help on using tickets.