Merge similar strings - failed to upload

[pavelevap]

Can we merge following similar strings?

“%s” has failed to upload.

“%s” has failed to upload due to an error

See attached patch.

[swissspidy]

Sounds good to me.

[juhise]

For making consistency in through out the admin, full stop not needed here.

[juhise]

updated patch file

[pavelevap]

There are many other strings with full stop, see "Upload stopped.", "File canceled.", "%s exceeds the maximum upload size for this site." and others. I only wanted to merge similar strings and avoid other discussion about related issues, because it would never be committed :-)

[juhise]

Replying to pavelevap:

There are many other strings with full stop, see "Upload stopped.", "File canceled.", "%s exceeds the maximum upload size for this site." and others. I only wanted to merge similar strings and avoid other discussion about related issues, because it would never be committed :-)

Yeah, But this string also didn't have full stop previously, So it would be great if we only remove the extra text (as suggest by you) and not add full stop. :)

[swissspidy]

Replying to juhise:

Replying to pavelevap:

There are many other strings with full stop, see "Upload stopped.", "File canceled.", "%s exceeds the maximum upload size for this site." and others. I only wanted to merge similar strings and avoid other discussion about related issues, because it would never be committed :-)

Yeah, But this string also didn't have full stop previously, So it would be great if we only remove the extra text (as suggest by you) and not add full stop. :)

But the other similar string has a full stop: “%s” has failed to upload.

This ticket is about making these strings the same, so both should have either a full stop or none. Considering the first string has had a full stop before, 33643.patch​ makes more sense to me.

[SergeyBiryukov]

In 33842:

Merge two similar strings.

props pavelevap.
fixes #33643.