WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33643 closed defect (bug) (fixed)

Merge similar strings - failed to upload

Reported by: pavelevap Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Can we merge following similar strings?

“%s” has failed to upload.

“%s” has failed to upload due to an error

See attached patch.

Attachments (2)

33643.patch (793 bytes) - added by pavelevap 4 years ago.
33643.1.patch (780 bytes) - added by juhise 4 years ago.
updated patch file

Download all attachments as: .zip

Change History (9)

@pavelevap
4 years ago

#1 @swissspidy
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to Future Release

Sounds good to me.

#2 @juhise
4 years ago

For making consistency in through out the admin, full stop not needed here.

@juhise
4 years ago

updated patch file

#3 follow-up: @pavelevap
4 years ago

There are many other strings with full stop, see "Upload stopped.", "File canceled.", "%s exceeds the maximum upload size for this site." and others. I only wanted to merge similar strings and avoid other discussion about related issues, because it would never be committed :-)

#4 in reply to: ↑ 3 ; follow-up: @juhise
4 years ago

Replying to pavelevap:

There are many other strings with full stop, see "Upload stopped.", "File canceled.", "%s exceeds the maximum upload size for this site." and others. I only wanted to merge similar strings and avoid other discussion about related issues, because it would never be committed :-)

Yeah, But this string also didn't have full stop previously, So it would be great if we only remove the extra text (as suggest by you) and not add full stop. :)

#5 in reply to: ↑ 4 @swissspidy
4 years ago

Replying to juhise:

Replying to pavelevap:

There are many other strings with full stop, see "Upload stopped.", "File canceled.", "%s exceeds the maximum upload size for this site." and others. I only wanted to merge similar strings and avoid other discussion about related issues, because it would never be committed :-)

Yeah, But this string also didn't have full stop previously, So it would be great if we only remove the extra text (as suggest by you) and not add full stop. :)

But the other similar string has a full stop: “%s” has failed to upload.

This ticket is about making these strings the same, so both should have either a full stop or none. Considering the first string has had a full stop before, 33643.patch makes more sense to me.

#6 @SergeyBiryukov
4 years ago

  • Milestone changed from Future Release to 4.4

#7 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 33842:

Merge two similar strings.

props pavelevap.
fixes #33643.

Note: See TracTickets for help on using tickets.