WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#33659 closed defect (bug) (fixed)

#a11y-headings - Widgets Page Sub Headings Should be h2 Instead of h3

Reported by: mrahmadawais Owned by: afercia
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: ui, accessibility Cc:

Description

#a11y-headings - Widgets Page Sub Headings Should be h2 Instead of h3, I found these headings at a glance "Active Widgets" and "Inactive Widgets".

Attachments (4)

33659.patch (1.6 KB) - added by mrahmadawais 5 years ago.
converts h3 to h2
33659.2.patch (2.1 KB) - added by mrahmadawais 5 years ago.
33659.3.patch (3.6 KB) - added by afercia 5 years ago.
33659.4.patch (4.2 KB) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (31)

@mrahmadawais
5 years ago

converts h3 to h2

#1 @mrahmadawais
5 years ago

  • Keywords has-patch dev-feedback added

This ticket was mentioned in Slack in #accessibility by mrahmadawais. View the logs.


5 years ago

#3 follow-up: @Cheffheid
5 years ago

It needs a little more work to take care of the "Inactive Widgets" heading, which seems to be a registered sidebar.

Take a look at wp-admin/includes/widgets.php - you'll find the headings for the sidebars and the widgets (which need to be bumped up from h4 to h3).

As a sidenote, it kind of overlaps with #33604 - which I'm going to close in favour of this ticket. But please make sure to not duplicate tickets. :)

#4 @Cheffheid
5 years ago

#33604 was marked as a duplicate.

#5 in reply to: ↑ 3 @mrahmadawais
5 years ago

Replying to Cheffheid:

It needs a little more work to take care of the "Inactive Widgets" heading, which seems to be a registered sidebar.

Take a look at wp-admin/includes/widgets.php - you'll find the headings for the sidebars and the widgets (which need to be bumped up from h4 to h3).

I will look into that, over the weekend.

As a sidenote, it kind of overlaps with #33604 - which I'm going to close in favour of this ticket. But please make sure to not duplicate tickets. :)

Damn :( I'll take care of this next time. I think I am searching with wrong queries for duplicates.

#6 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to afercia
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core by sergey. View the logs.


5 years ago

#8 @SergeyBiryukov
5 years ago

  • Keywords needs-patch added; has-patch removed

This ticket was mentioned in Slack in #accessibility by mrahmadawais. View the logs.


5 years ago

#10 @mrahmadawais
5 years ago

  • Keywords has-patch added; needs-patch removed

Sidebar headings are now bumped up from h3 to h2. Including Inactive Widgets.

#11 follow-up: @afercia
5 years ago

We should also bump up all the widgets title headings from <h4> to <h3> and update the CSS accordingly. There are also a couple of jQuery selectors to adjust in /wp-admin/js/widgets.js, currently the available widgets are broken when expanded:

https://cldup.com/l7X8UUoKp9.png

Please consider there are also the "accessible mode" screens to check, see under "Screen Options > Enable accessibility mode".

#12 in reply to: ↑ 11 ; follow-up: @mrahmadawais
5 years ago

Replying to afercia:

We should also bump up all the widgets title headings from <h4> to <h3> and update the CSS accordingly. There are also a couple of jQuery selectors to adjust in /wp-admin/js/widgets.js, currently the available widgets are broken when expanded:

https://cldup.com/l7X8UUoKp9.png

Please consider there are also the "accessible mode" screens to check, see under "Screen Options > Enable accessibility mode".

Why is it breaking up like this? What am I missing?

#13 in reply to: ↑ 12 @afercia
5 years ago

Replying to mrahmadawais:

Why is it breaking up like this? What am I missing?

@mrahmadawais if you have a look at /wp-admin/js/widgets.js you will notice there are a couple of jQuery selectors to update.

@afercia
5 years ago

#14 follow-up: @afercia
5 years ago

  • Keywords dev-feedback removed

Refreshed patch to take care of the widgets title headings (bumping them up from <h4> to <h3>) and update the jQuery selectors.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 years ago

#16 @Cheffheid
5 years ago

Looks good! :thumbsup:

Heading wise, anyway. Keyboard-wise the page is a mess. But that's something for another ticket. :)

#17 in reply to: ↑ 14 @mrahmadawais
5 years ago

Replying to afercia:

Refreshed patch to take care of the widgets title headings (bumping them up from <h4> to <h3>) and update the jQuery selectors.

Thanks. Looks good. I am so caught up in the mess at office, that couldn't get time to refresh the patch.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 years ago

@afercia
5 years ago

#19 @afercia
5 years ago

Refreshed patch to take into account the .widget-title headings in the Customizer.

This ticket was mentioned in Slack in #core-customize by afercia. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by afercia. View the logs.


5 years ago

#22 follow-up: @ocean90
5 years ago

33659.4.patch should we duplicate the rules in customize-widgets.css too? Otherwise it looks good.

#23 in reply to: ↑ 22 @afercia
5 years ago

Replying to ocean90:

33659.4.patch should we duplicate the rules in customize-widgets.css too? Otherwise it looks good.

As long as the Customizer will use /wp-admin/css/widgets.css, there's probably no need to duplicate the rules. I can't see any visual change with the patch applied, unless I'm missing something. As per the headings hierarchy within the Customizer, that's a whole new chapter to write and it will need research, development, and new, separate, tickets :)

#24 @afercia
5 years ago

  • Focuses ui added

This ticket was mentioned in Slack in #core by afercia. View the logs.


5 years ago

#26 follow-up: @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35015:

Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy.

Props mrahmadawais, afercia.
Fixes #33659.

#27 in reply to: ↑ 26 @mrahmadawais
5 years ago

Replying to afercia:

In 35015:

Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy.

Props mrahmadawais, afercia.
Fixes #33659.

Great!

Note: See TracTickets for help on using tickets.