Create pretty permalinks for unlinked attachments

[pfefferle]

The URL of an unlinked attachments always uses query params (for example: ​http://notizblog.org/?attachment_id=6702) if pretty permalinks are enabled or not.

This causes problems with feed links (for example: ​http://notizblog.org/?attachment_id=6702/feed/) and any other plugins that are using add_rewrite_endpoint (for example: ​https://github.com/swissspidy/oEmbed-API/blob/master/classes/class-plugin.php#L88)

[swissspidy]

I can confirm this. The error lies in get_post_comments_feed_link which just appends /feed/ to the permalink if pretty permalinks are enabled. It should check for unattached attachments though.

[pfefferle]

I think it is more consistent to use a simple pretty permalink for the attachment (for example ​http://notizblog.org/attachment/6702) because a lot of plugins might make the same mistake (like we did with the oEmbed API plugin). It is recommended on several codex pages to check the permalink structure like this:

<?php if ( get_option('permalink_structure') ) { echo 'permalinks enabled'; } ?>

​https://codex.wordpress.org/Using_Permalinks

[swissspidy]

I created #33693 for the feed link problem, leaving this ticket for discussing the permalink stuff.

[SergeyBiryukov]

Duplicate of #1914.