Menu Customizer: Implement indicators for invalid menu items

[pavelevap]

I sometimes found some mistake when menu contained obsolete items (for example not used post type, etc). Standard admin menu page shows notice (as soon as user visits this page) that something is wrong and all related items are red. But in Customizer it does not work?

[westonruter]

Yes, this is something that was left as a todo in the implementation of Menus in the Customizer for 4.3, as can be seen here: https://core.trac.wordpress.org/browser/tags/4.3/src/wp-includes/class-wp-customize-setting.php#L687

The wp_setup_nav_menu_item() function sets an _invalid property if the object that the item refers to is gone (i.e. obsolete). So this needs to be exposed as a read-only property of the nav_menu_item setting, probably in WP_Customize_Nav_Menu_Item_Setting::value()

[pavelevap]

Greta. And one more inconsistency: I can add draft items to menu (admin page), but it is not possible in Customizer.

[atomicjack]

Replying to pavelevap:

Greta. And one more inconsistency: I can add draft items to menu (admin page), but it is not possible in Customizer.

That's for a separate ticket. ;)

[pavelevap]

Done: #33742

[kucrut]

Implement indicators for invalid menu items

[westonruter]

See also PR for attached patch: ​https://github.com/xwp/wordpress-develop/pull/119

[DrewAPicture]

@westonruter How's this looking? Looks like maybe we still need unit tests?

[westonruter]

@pavelevap Can you test the patch and confirm it resolves the issue you reported?

[pavelevap]

Looks good to me, great work!

It seems to me that opening panel with menu is a little bit slower then before applying patch, but I did not have the time to test it better (and menu is large, more than 50 items)...

[westonruter]

Additional change: ​https://github.com/xwp/wordpress-develop/commit/b8642aeb602c11430de9fed6f041e1e187709ce0

[westonruter]

33665.2.diff​ ensures that _invalid is always set and it is sanitized, and also adds unit tests.

[westonruter]

In 35302:

Customizer: Implement indicators for invalid nav menu items.

The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.

Props kucrut, westonruter.
Fixes #33665.