WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#3367 closed enhancement (fixed)

Single quote around double quote mysql string breaks on OpenVMS HP-PHP

Reported by: WillemGrooters Owned by:
Milestone: 2.0.6 Priority: normal
Severity: normal Version: 2.0.5
Component: Optimization Keywords: has-patch
Focuses: Cc:

Description

For having Wordpress run under OpenVMS, I would like to suggest a change to classes.php. lines 600-616:
These lines contain a mixture of single and double quotes that the HP-PHP engine cannot handle. It's the only place where strings are delimited by single quotes, and values with double, like this (line 600)

if ( $this->is_attachment ) {
$where .= ' AND (post_status = "attachment")';

This causes errors in accessing MySQL via PHP; the very same problem arises when the SQL-command is issues within PHPMyAdmin, though MYSQL itself has no trouble with it.

If this is changed so strings are delimited by double quotes and the values with single:

if ( $this->is_attachment ) {
$where .= " AND (post_status = 'attachment')";

the problems are over.
Secondly, this is more consistent to the rest of the code, for what I have examined.

Attachments (2)

3367-patch.txt (1.1 KB) - added by foolswisdom 7 years ago.
3367.diff (1.1 KB) - added by foolswisdom 7 years ago.
Attaching again b/c .txt don't get the fancy diff when viewing attach

Download all attachments as: .zip

Change History (7)

comment:1 foolswisdom7 years ago

  • Milestone set to 2.1
  • Summary changed from Proposed change to Single quote around double quote mysql string breaks on OpenVMS HP-PHP

Hi Willem, thank you for participating in WordPress!

"Proposed change" is a really lousy bug Summary.

Next time please attach a patch (preferably also against trunk). I am working on patch now.

comment:2 foolswisdom7 years ago

  • Milestone changed from 2.1 to 2.0.5

Problem does not exist in trunk, function is now in wp-includes/query.php and looks like the quotes have been fixed.

No milestone 2.0.6, putting ms to 2.0.5 for now.

foolswisdom7 years ago

foolswisdom7 years ago

Attaching again b/c .txt don't get the fancy diff when viewing attach

comment:3 foolswisdom7 years ago

  • Keywords has-patch maint-candidate added

comment:4 foolswisdom7 years ago

  • Keywords maint-candidate removed
  • Milestone changed from 2.0.5 to 2.0.6

comment:5 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4493]) Quote strings in SQL with single quotes instead of double quotes to be more correct and consistent. Props WillemGrooters. fixes #3367

Note: See TracTickets for help on using tickets.