Cheatin' uh?: Update in wp-includes/class-wp-customize-manager.php

[kraftbj]

Spin off of #14530 to track updating the Cheatin error message to something context specific. Patch needs to be split off of original ticket.

[kraftbj]

initial patch

[kraftbj]

This file has a custom wp_die handler, so I applied the logic and spirit of #14530 like this:

• "Upstream" from the actual wp_die call, I added error messages to each instance of the class' wp_die function.
• For the generic theme error return, I used $this->theme()->errors()->get_error_message(). To follow the chain, the class' theme() calls wp_get_theme, which is a WP_Theme object. WP_Theme::errors() returns the WP_Error object, so get_error_message returns the pretty error message.

An example to test that error message:

0. WordPress install with multiple themes installed. Access the Customizer. Preview theme A.
1. From another window, delete theme B.
2. From the original window, attempt to Live Preview theme A.

The result will be the attached screenshot.

[kraftbj]

sample of the dynamic error response.

[SergeyBiryukov]

In 33889:

Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-includes/class-wp-customize-manager.php.

props kraftbj.
fixes #33684. see #14530.

[GaryJ]

Do wp_die() messages need to be translatable? If we're going to be giving messages that pertain to being more useful to the user that caused them, then being able to have those messages in the user's desired language has got to be a necessity?

[GaryJ]

Re-opening, as I've now seen that sibling commits do indeed have translatable strings, which simply got missed for this ticket.

[kraftbj]

The upstream error messages should already be translated, but I did overlook that when adding these. Patch incoming.

[kraftbj]

add translation functions

[SergeyBiryukov]

In 33892:

Add missing translation functions to the error messages added in [33889].

props kraftbj, GaryJ.
fixes #33684.