WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#33685 closed enhancement (fixed)

Cheatin' uh?: Update in wp-includes/script-loader.php

Reported by: kraftbj Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Role/Capability Keywords:
Focuses: ui Cc:

Description

Spin off of #14530 to track updating the Cheatin error message to something context specific. Patch needs to be split off of original ticket.

Attachments (2)

33685.diff (634 bytes) - added by kraftbj 3 years ago.
initial patch, uses existing string
33685.2.diff (1.7 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (7)

@kraftbj
3 years ago

initial patch, uses existing string

#1 @pavelevap
3 years ago

This change is not very specific :-) Why switching from "Cheating" (preserved in all other cases) to "WordPress Error"?

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 4.4

#3 @SergeyBiryukov
3 years ago

Yeah, the string in used in a <p> tag and not in a header, as in wp_die().

For consistency with other changes, I'd suggest something like 33685.2.diff.

(body.cheatin h1 styles are copied from wp_die(), like body.cheatin p earlier.)

#4 @kraftbj
3 years ago

No objection to .2. It does make it consistent with the other changes in this series.

#5 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 33902:

Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/js/customize-controls.js.

fixes #33685. see #14530.

Note: See TracTickets for help on using tickets.