WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#33689 closed defect (bug) (fixed)

wp_check_php_mysql_versions should send a 500 on errors

Reported by: jeichorn Owned by: johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Bootstrap/Load Keywords: has-patch
Focuses: Cc:

Description

When the wp_check_php_mysql_versions() fails the error message that is returned is a 200 status code, it should be a 500.

A patch on load.php is included using wp_maintenance() as the template

Attachments (2)

load.php.patch.txt (630 bytes) - added by jeichorn 5 years ago.
load.php.patch (630 bytes) - added by jeichorn 5 years ago.

Download all attachments as: .zip

Change History (5)

#1 @DrewAPicture
5 years ago

  • Keywords has-patch added

Hi @jeichorn, thanks for the patch! Unfortunately it looks like it's formatted as a text file. Can you try re-uploading it with a .diff or .patch extension?

@jeichorn
5 years ago

#2 @johnbillion
5 years ago

  • Milestone changed from Awaiting Review to 4.4

#3 @johnbillion
5 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 34462:

Send a 500 HTTP response code when the server's PHP or MySQL checks fail.

Fixes #33689
Props jeichorn

Note: See TracTickets for help on using tickets.