#33695 closed defect (bug) (fixed)
Customize: shift-clicking a widget in the preview doesn't move focus
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.3.1 | Priority: | normal |
| Severity: | normal | Version: | 4.3 |
| Component: | Customize | Keywords: | has-patch commit fixed-major |
| Focuses: | ui, accessibility, javascript | Cc: |
Description
See related #33258 and #33220.
Looks like after 33610 when shift clicking a widget in the preview iframe the widget correctly opens in the sidebar but focus doesn't get moved to the first focusable element in the sidebar expanded panel.
As far as I remember, it correctly worked after 33596. Broken now probably because it returns a wrong "focusContainer" since the first ul there is the (hidden) one inside .move-widget-area.
Attachments (1)
Change History (9)
This ticket was mentioned in Slack in #core-customize by afercia. View the logs.
9 years ago
#2
follow-up:
↓ 3
@
9 years ago
- Keywords has-patch added
- Owner set to westonruter
- Status changed from new to accepted
#3
in reply to:
↑ 2
@
9 years ago
@westonruter thanks :)
Should this not be milestoned for 4.3.1?
Actually, I wasn't sure what to do when setting the milestone :)
Note: See
TracTickets for help on using
tickets.
@afercia: Nice catch. See 33695.diff which has the fix. The problem is that widgets also have an
expandedproperty, so they incorrectly get interpreted as a panel/section. So we just have to be more explicit about the different construct types when determining the focus container.Should this not be milestoned for 4.3.1?