Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #33704, comment 2


Ignore:
Timestamp:
08/26/2016 04:56:25 PM (8 years ago)
Author:
akibjorklund
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33704, comment 2

    initial v1  
    3131'''8. Customizer: 4 instances
    3232
    33 `class-wp-customize-manager.php` and `theme.php` set some variables for mobile and ios to pass them to JavaScript. I found only one instance that uses those: customizer widgets do similar autofocus that category #1 instances do. There could be more uses for these and themes could use these variables as well.
     33`class-wp-customize-manager.php` and `theme.php` set some variables for mobile and ios to pass them to JavaScript. I found only one instance that uses those: customizer widgets do similar autofocus that category 1 instances do. There could be more uses for these and themes could use these variables as well.
    3434
    3535'''9. Login shake: 1 instance
     
    4141All of those might require a different approach. Should there be a ticket for each of those categories with individual patches or should there be one giant patch within this ticket?
    4242
    43 Related: browser globals (`$is_lynx`, `$is_edge`, `$is_chrome`, etc.) are also determined from the `USER_AGENT` header and are just as evil. I hope no-one is using them to detect Netscape 4 anymore for example. This definitely is a topic for another ticket though.
     43Related: browser globals (`$is_lynx`, `$is_edge`, `$is_chrome`, etc.) are also determined from the `User-Agent` header and are just as evil. I hope no-one is using them to detect Netscape 4 anymore for example. This definitely is a topic for another ticket though.