WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #33717, comment 59


Ignore:
Timestamp:
12/13/2019 09:50:36 AM (23 months ago)
Author:
imath
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33717, comment 59

    initial v1  
    1616About 3) Using a cookie would only avoid 1 click for the 2nd option, I'm not sure it saves the comment author so much time as he would need to submit the form anyway. But if we think it's absolutely required, then why not ;)
    1717
    18 About 4) I agree we need to make sure the form is notification opt-in form is not output if the site owner removed the hook that triggers the notification. In other words, using `remove_action( 'comment_unapproved_to_approved', 'wp_new_comment_notify_comment_author' );` is disabling the feature. I think if we can avoid a new option into the Discussion settings, it's always better. [https://core.trac.wordpress.org/attachment/ticket/33717/33717.12.diff 33717.12.diff] has been improved to handle this case.
     18About 4) I agree we need to make sure the notification opt-in form is not output if the site owner removed the hook that triggers the notification. In other words, using `remove_action( 'comment_unapproved_to_approved', 'wp_new_comment_notify_comment_author' );` is disabling the feature. I think if we can avoid a new option into the Discussion settings, it's always better. [https://core.trac.wordpress.org/attachment/ticket/33717/33717.12.diff 33717.12.diff] has been improved to handle this case.