Allow WP_Post on thumbnail functions

[Rahe]

Since we can put WP_Post object as argument for get_the_title() or get_permalink() it can be nice to have theses on the thumbnail functions.

Here's my patch containing the changes for handling this kind of improvements and coding standards applyed.

[swissspidy]

Thanks for your patch! I think this enhancements makes sense as it is more convenient for developers.

Unfortunately I wasn't able to easily apply it because of the base directory. As a tip for next time, please make sure you patch from the /src directory, so it looks like src/wp-includes/post-thumbnail-template.php in your patch.

I created 33723.diff​ now that does the following:

• Adds @since to the docblocks to reflect the changes
• Leaves update_post_thumbnail_cache alone. We don't do refactoring just for the sake of refactoring, see ​https://make.wordpress.org/core/2011/03/23/code-refactoring/ for details.
• Makes sure $post is a WP_Post in get_post_thumbnail_id, otherwise uses null

Unfortunately these functions have no unit tests. We really should add some, but maybe in a separate ticket.

[DrewAPicture]

Replying to swissspidy:

Unfortunately these functions have no unit tests. We really should add some, but maybe in a separate ticket.

Unit tests should ship with the changes here in the same ticket.

[swissspidy]

Adds unit tests

[swissspidy]

Oh noes, looks like I attached the same again by mistake.

[swissspidy]

Unit tests, now for real

[swissspidy]

33723.4.diff​ improves the inline docs even more.

I'd say this could safely make it into core now, but of course a second pair of eyes would be great.

[DrewAPicture]

@swissspidy: The docs look pretty good. The only thing missing is that all of the functions that accept $post = null default to the global $post, therefore the parameter should be documented as optional, and mention that it defaults to the global $post.

[swissspidy]

All good things go by six. The new patch mentions that the global $post is the default.

[wonderboymusic]

I'm gonna look at this

[wonderboymusic]

In 34167:

Update post thumbnail functions to allow a WP_Post to be passed.

Adds unit tests.

Props swissspidy, Rahe.
Fixes #33723.