WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33725 closed defect (bug) (fixed)

@access parameter missing in class-wp-filesystem-direct.php

Reported by: wenthemes Owned by: swissspidy
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: General Keywords: has-patch
Focuses: docs Cc:
PR Number:

Description

@access parameter missing in methods of WP_Filesystem_Direct class.

File: class-wp-filesystem-direct.php
Path: wp-admin/includes/

Attachments (2)

33725.diff (4.5 KB) - added by wenthemes 4 years ago.
33725-2.diff (4.7 KB) - added by wenthemes 4 years ago.
patch refreshed

Download all attachments as: .zip

Change History (9)

@wenthemes
4 years ago

#1 @wenthemes
4 years ago

  • Keywords has-patch 2nd-opinion added

#2 @swissspidy
4 years ago

Hey there,

thanks for reporting this and writing a patch! According to the WordPress PHP documentation standards, there should be a blank line between@access and @param. Can you update the patch accordingly?

#3 @swissspidy
4 years ago

  • Milestone changed from Awaiting Review to 4.4

#4 @DrewAPicture
4 years ago

  • Keywords 2nd-opinion removed
  • Owner set to swissspidy
  • Status changed from new to reviewing

#5 @wenthemes
4 years ago

Ok, I will refresh the patch and re-upload.

@wenthemes
4 years ago

patch refreshed

#6 @SergeyBiryukov
4 years ago

Seems like other class-wp-filesystem-*.php files should be patched as well.

#7 @wonderboymusic
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 33984:

Add @access docs to class-wp-filesystem-* files.

Props wenthemes.
Fixes #33725.

Note: See TracTickets for help on using tickets.