Make WordPress Core

Opened 9 years ago

Closed 8 years ago

#33747 closed defect (bug) (fixed)

Reorder and Done need different context?

Reported by: pavelevap's profile pavelevap Owned by: ocean90's profile ocean90
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch has-ux-feedback
Focuses: Cc:

Description

There are same buttons Reorder and Done for Menus and Widgets, but with different context. But these buttons are for same action (reordering items) and we do not need different context here?

Attachments (2)

33747.diff (2.3 KB) - added by Presskopp 8 years ago.
33747.2.diff (2.3 KB) - added by Presskopp 8 years ago.

Download all attachments as: .zip

Change History (12)

#1 @wonderboymusic
9 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to ocean90
  • Status changed from new to assigned

#2 @ocean90
9 years ago

  • Milestone 4.4 deleted
  • Resolution set to invalid
  • Status changed from assigned to closed

There are locales which have translated the strings differently, so yes.

#3 @pavelevap
9 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

Yes, that was the point of this ticket :-) I also translated it differently before I found that we have same string, only with different context. For example "Reorder" is common verb and can be translated differently by different translators, when they do not notice other string. But for consistency in Customizer UI, it should be only one string (button) and it would be helpfull also for translators...

Or we should add different context also for many other general strings, for example "Bulk Edit", "Quick Edit" or "Publish" and "Update" buttons, which should have different context for Posts, Pages, Users, etc.

#4 @ocean90
9 years ago

  • Component changed from I18N to Customize
  • Milestone set to Awaiting Review
  • Version changed from trunk to 4.3

How about a patch?

#5 @swissspidy
9 years ago

  • Keywords needs-patch added

@Presskopp
8 years ago

#6 @Presskopp
8 years ago

  • Keywords has-patch added; needs-patch removed

synchronized to

<span class="reorder"><?php _ex( 'Reorder', 'Reorder items in Customizer' ); ?></span>
<span class="reorder-done"><?php _ex( 'Done', 'Cancel reordering items in Customizer' ); ?></span>

Didn't touch the screen-reader-text part

#7 @karmatosed
8 years ago

  • Keywords has-ux-feedback added

Just to confirm those trying to replicate this, it only shows in some languages as an issue. For example, I can't see this as an issue in English.

With regards to the patch, wouldn't 'done reordering' make more sense? Or is that a translation issue?

@Presskopp
8 years ago

#8 @Presskopp
8 years ago

It makes more sense definitely. Changed.

#9 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 4.8

I think we can just remove the redundant context here (introduced in [27985] without an explanation):

  • Reorder is not used anywhere else in core.
  • Done is used in Press This and the old media UI for setting post thumbnails, but in a similar context.

#10 @SergeyBiryukov
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 39927:

Customize: Remove redundant context for "Reorder" and "Done" strings in nav menu and widget area controls to ensure consistent translations.

Props pavelevap, Presskopp.
Fixes #33747.

Note: See TracTickets for help on using tickets.