Reorder and Done need different context?

[pavelevap]

There are same buttons Reorder and Done for Menus and Widgets, but with different context. But these buttons are for same action (reordering items) and we do not need different context here?

[ocean90]

There are locales which have translated the strings differently, so yes.

[pavelevap]

Yes, that was the point of this ticket :-) I also translated it differently before I found that we have same string, only with different context. For example "Reorder" is common verb and can be translated differently by different translators, when they do not notice other string. But for consistency in Customizer UI, it should be only one string (button) and it would be helpfull also for translators...

Or we should add different context also for many other general strings, for example "Bulk Edit", "Quick Edit" or "Publish" and "Update" buttons, which should have different context for Posts, Pages, Users, etc.

[ocean90]

How about a patch?

[Presskopp]

synchronized to

<span class="reorder"><?php _ex( 'Reorder', 'Reorder items in Customizer' ); ?></span>
<span class="reorder-done"><?php _ex( 'Done', 'Cancel reordering items in Customizer' ); ?></span>

Didn't touch the screen-reader-text part

[karmatosed]

Just to confirm those trying to replicate this, it only shows in some languages as an issue. For example, I can't see this as an issue in English.

With regards to the patch, wouldn't 'done reordering' make more sense? Or is that a translation issue?

[Presskopp]

It makes more sense definitely. Changed.

[SergeyBiryukov]

I think we can just remove the redundant context here (introduced in [27985] without an explanation):

• Reorder is not used anywhere else in core.
• Done is used in Press This and the old media UI for setting post thumbnails, but in a similar context.

[SergeyBiryukov]

In 39927:

Customize: Remove redundant context for "Reorder" and "Done" strings in nav menu and widget area controls to ensure consistent translations.

Props pavelevap, Presskopp.
Fixes #33747.