WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#33758 closed task (blessed) (fixed)

Bump Recommended PHP version

Reported by: pento Owned by: pento
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: docs Cc:
PR Number:

Description

readme.html currently lists PHP 5.4 as the recommended version, which reaches EOL in a few days.

I'm inclined to skip 5.5 and bump it to 5.6 - 5.5 is in extended support, only receiving security fixes. 5.6 is still well within active support.

I have no problem leaving MySQL at 5.5, which is still in active support. We can bump the MySQL version to 5.6 when we do #32105.

Related: #meta802.

Change History (9)

#1 @netweb
4 years ago

  • Keywords good-first-bug added

#2 @pento
4 years ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 33937:

Readme: Update the recommended PHP version to 5.6.

This also includes a unit test to ensure we're only recommending actively supported versions of PHP in the future.

Fixes #33758.

#3 @pento
4 years ago

In 33944:

Tests: Add an extra warning message when checking the recommended PHP version.

See #33758.

#4 @pento
4 years ago

In 33946:

Tests: Check that readme.html is recommending an actively supported version of MySQL.

Per the MySQL support guidelines (https://www.mysql.com/support/), Oracle provides active support for MySQL releases for 5 years from the General Availality release.

See #33758.

#5 @tenpura
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Should this be reflected to 4.3 branch?

#6 @jorbin
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

No, this is closed againgst 4.4. No need to change recommendations for an already released version.

#7 @tenpura
4 years ago

@jorbin If this is againgst 4.4, The Requirements page should not state so yet. It may confuse people.

https://wordpress.org/about/requirements/

#8 @knutsp
4 years ago

  • Keywords good-first-bug removed

@tenpura is right, even if it may be considered minor.

User who

  1. View requirements on wp.org and find the recommended PHP version to be 5.6
  2. Asks Host A, who only can offer PHP 5.4
  3. Asks Host B, who can offer PHP 5.6
  4. Downloads current WordPress (4.3.1) for Host B
  5. Reads readme.html and now find that recommended PHP version is 5.4

rightfully becomes confused.

No need to change recommendations for all previously released versions, but there is a need to change recommendations for current version as soon as possible after the official change on wp.org.

Ideally

  • Milestone this ticket to 4.3.2 and commit patch to branch
  • Consider silently repackage 4.3.1 with this new readme.html (as long as 4.3.1 is still current)

or regard the risk of confusion as minor.

#9 @pento
4 years ago

I think the risk of confusion is small enough that we can leave it as is in the 4.3 branch. I also don't think this is severe enough to be changing strings in a stable branch.

I'm inclined to look at about/requirements as reflecting the current best practices, which is not necessarily tied to a specific version of WordPress. 4.3 and trunk already run on PHP 7, but we won't be updating their readme's or about/requirements to recommend PHP 7 until it's been out for a while. When we do update to recommend PHP 7, we'll be comfortable that several major versions work on it, so we don't need to worry about people running a more recent version of PHP than their WordPress install supports.

That said, if we do have instances of folks being confused by the differing recommendations, I have no problem with revisiting this and seeing if we can make things clearer.

Note: See TracTickets for help on using tickets.