WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#33777 closed defect (bug) (fixed)

Duplicate string - Open link in a new tab

Reported by: pavelevap's profile pavelevap Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

We have two duplicate strings:

Open link in a new tab (Menu Customizer)

Open link in a new window/tab (Menu page, Link modal)

I can create patch, but I am not sure which one is better? First one was created for Menus in Customizer, second is older. But there is no reason to have both, I guess...

Attachments (2)

33777.diff​ (744 bytes) - added by dipesh.kakadiya 10 years ago.
Updated string as 'Open link in a new window/tab'. As I check code every where given strign is used.
33777_1.diff​ (2.3 KB) - added by dipesh.kakadiya 10 years ago.
Update short string Open link in a new tab

Download all attachments as: .zip

Change History (6)

@dipesh.kakadiya
10 years ago

Updated string as 'Open link in a new window/tab'. As I check code every where given strign is used.

#1 @dipesh.kakadiya
10 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.4

Let's go with the first one, it's hard to find a browser without tabs these days :)

#3 @pavelevap
10 years ago

I agree, shorter string was probably created to better fit in Customizer...

@dipesh.kakadiya
10 years ago

Update short string Open link in a new tab

#4 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 33998:

Merge two similar strings.

Props dipesh.kakadiya.
Fixes #33777.

Note: See TracTickets for help on using tickets.