Password label not focussing password field when clicked

[umesh.nevase]

When we click on password label on wordpress install page, the password text field not getting focussed. When we click on hide button and then click on 'Password' label then the password text field gets focussed. It is little bit confusing the user, whether to edit or not the password.

[umesh.nevase]

Password label is not working

[umesh.nevase]

patch file for the issue, I've made changes in user-profile.js

[joedolson]

This seems like a pretty major bug that needs to go into 4.3.1. Thanks for reporting!

[umesh.nevase]

Fixed issue for user edit and add new user page. This is working latest patch

[umesh.nevase]

I've added new patch ( 33778.2.patch ) which is also works on user edit and add new user page. I've found the same issue on User edit page and Add new user page.

[adamsilverstein]

@umesh.nevase:

Thanks for the bug report and patch.

This makes sense as we are swapping fields and need to keep track of where the focus should go. I will give this patch a test.

[juhise]

Replying to adamsilverstein:

Already reported. Seems similar to https://core.trac.wordpress.org/ticket/33647

[umesh.nevase]

same issue also exists on New user and Edit profile pages. I've added id and script that handled the issue for all ( Install.php, user-new.php, profile.php ) password label

[umesh.nevase]

@juhise I've seen same issue also exists on 'User profile' and 'New user' page. I added id field for 'Generate Password' button and added script to handle these issue. I've created new patch 33778.3.patch for all the issues ( install.php, pofile.php, user-new.php)

[umesh.nevase]

handled issue after canceling the password, when user clicks on 'cancel' button label for attribute set to wp-generate-pw

[umesh.nevase]

if javascript disabled handled password label to set 'pass1' focus and previous issue patch and this is final patch

[adamsilverstein]

@umesh.nevase: Thanks for the updated patch, I will test!

[azaozz]

Looking at 33778.5.patch: it "points" the label to the Show password button. However clicking on a label for a button is pretty much the same as clicking the button. Do we want that behavior?

[azaozz]

In 33778.6.patch:

• Better caching and reusing of selected elements.
• Fixed formatting.

It still includes the label pointing to a button parts.

[afercia]

Replying to azaozz:

it "points" the label to the Show password button. However clicking on a label for a button is pretty much the same as clicking the button. Do we want that behavior?

I'd recommend to avoid that, it's unexpected behavior and pretty confusing for all users.

[azaozz]

In 34061:

Settings: reassign the label when switching password fields so it always highlights the visible field.

Props umesh.nevase.
Fixes #33778 for trunk.

[azaozz]

Reopen for 4.3.

[azaozz]

In 34062:

Settings: properly set the password field label on loading.

See #33778.

[azaozz]

In 34063:

Settings: reassign the label when switching password fields so it always highlights the visible field.

Props umesh.nevase.
Fixes #33778 4.3.

[umesh.nevase]

Replying to azaozz:

In 34063:

Settings: reassign the label when switching password fields so it always highlights the visible field.

Props umesh.nevase.
Fixes #33778 4.3.

@azaozz

I hope we also fixed same issue for 'User profile' and 'New user' page.
I had added patch in 33778.5.patch​ for the issue of this pages. because I could not see changes for profile page and new user page in commit or changeset 34061, 34062 and 34063.

Should I create new ticket for this issues