The WP Admin bar secondary item tab's arrow, are opening in wrong direction in RTL sites.

[Ankit K Gupta]

In WP Admin bar secondary item tab's arrow, are opening in wrong direction in RTL sites. It should open in same direction of opened sub-items list.

[Ankit K Gupta]

screen shot of rtl site

[Ankit K Gupta]

patch file

[Ankit K Gupta]

screen shot after patch

[netweb]

Thanks Ankit,

Strange this isn't currently working, we actually as part of our build process swap /f141 for /f139 for our RTL CSS:

https://core.trac.wordpress.org/browser/trunk/Gruntfile.js#L206

I'll go take a closer look and find out why it's not working as expected

[Ankit K Gupta]

Replying to netweb:

Thanks Ankit,

Strange this isn't currently working, we actually as part of our build process swap /f141 for /f139 for our RTL CSS:

https://core.trac.wordpress.org/browser/trunk/Gruntfile.js#L206

I'll go take a closer look and find out why it's not working as expected

@netweb,
It's my Pleasure.

Thanks for your quick response :)

[yoavf]

@netweb - swap-dashicons-left-right-arrows expects double quotes. 33786.diff​ should take care of that.

[netweb]

Replying to yoavf:

@netweb - swap-dashicons-left-right-arrows expects double quotes. 33786.diff​ should take care of that.

Right, thanks, also a couple more instances, patch and further details below.

Per CSS Coding standards: ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/#values

• Use double quotes rather than single quotes, and only when needed, such as when a font name has a space.

Patch 33786.2.diff fixes all occurrences of single quotes, missing semi colon, or white space after the colon so that each instance is formatted per our coding standards e.g. content: "\f139";

The resulting patch 33786.2.diff may any other day be seen as ​“Code refactoring should not be done just because we can.” – Lead Developer Andrew Nacin though in this case by normalising these instances we're able to accurately and dynamically search and replacing these values as part of our Grunt build process here

The results of this patch is many other instances not just the original reported instance where the dashicon had not been replaced by the RTL equivalent per our Gruntfile.js in our Grunt build tools.

Note: 33786.2.diff only touches /wp-admin and /wp-includes, themes in /wp-content should be tackled in a separate ticket.

[wonderboymusic]

In 34011:

Grunt RTL CSS: swap-dashicons-left-right-arrows in rtlcss:properties expects double-quoted content strings in CSS. It doesn't swap single-quoted values.

Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.