Opened 9 years ago
Closed 9 years ago
#33786 closed defect (bug) (fixed)
The WP Admin bar secondary item tab's arrow, are opening in wrong direction in RTL sites.
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Administration | Keywords: | has-patch |
Focuses: | ui, accessibility, rtl, administration | Cc: |
Description
In WP Admin bar secondary item tab's arrow, are opening in wrong direction in RTL sites. It should open in same direction of opened sub-items list.
Attachments (5)
Change History (11)
#2
follow-up:
↓ 3
@
9 years ago
- Milestone changed from Awaiting Review to 4.4
- Owner set to netweb
- Status changed from new to assigned
Thanks Ankit,
Strange this isn't currently working, we actually as part of our build process swap /f141
for /f139
for our RTL CSS:
https://core.trac.wordpress.org/browser/trunk/Gruntfile.js#L206
I'll go take a closer look and find out why it's not working as expected
#3
in reply to:
↑ 2
@
9 years ago
Replying to netweb:
Thanks Ankit,
Strange this isn't currently working, we actually as part of our build process swap
/f141
for/f139
for our RTL CSS:
https://core.trac.wordpress.org/browser/trunk/Gruntfile.js#L206
I'll go take a closer look and find out why it's not working as expected
@netweb,
It's my Pleasure.
Thanks for your quick response :)
#4
follow-up:
↓ 5
@
9 years ago
@netweb - swap-dashicons-left-right-arrows
expects double quotes. 33786.diff should take care of that.
#5
in reply to:
↑ 4
@
9 years ago
Replying to yoavf:
@netweb -
swap-dashicons-left-right-arrows
expects double quotes. 33786.diff should take care of that.
Right, thanks, also a couple more instances, patch and further details below.
Per CSS Coding standards: https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/#values
Use double quotes rather than single quotes, and only when needed, such as when a font name has a space.
Patch 33786.2.diff fixes all occurrences of single quotes, missing semi colon, or white space after the colon so that each instance is formatted per our coding standards e.g. content: "\f139";
The resulting patch 33786.2.diff may any other day be seen as “Code refactoring should not be done just because we can.” – Lead Developer Andrew Nacin though in this case by normalising these instances we're able to accurately and dynamically search and replacing these values as part of our Grunt build process here
The results of this patch is many other instances not just the original reported instance where the dashicon had not been replaced by the RTL equivalent per our Gruntfile.js
in our Grunt build tools.
Note: 33786.2.diff only touches /wp-admin
and /wp-includes
, themes in /wp-content
should be tackled in a separate ticket.
screen shot of rtl site