#33798 closed task (blessed) (fixed)
Upgrade MediaElement to 2.18.1
Reported by: | wonderboymusic | Owned by: | wonderboymusic |
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | 4.4 |
Component: | External Libraries | Keywords: | |
Focuses: | javascript | Cc: |
Description
Changelog: https://github.com/johndyer/mediaelement/compare/2.17.0...2.18.1
This might require monkey-patching, which I'll do.
Attachments (2)
Change History (11)
#5
@
9 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
There was a breaking API change in one of the public methods in 2.18 that's throwing errors everywhere I'm using it. I submitted a PR upstream to fix backward compatibility and it got merged a couple days ago.
What's the best way of getting that incorporated here? Can I cherry pick that commit and apply it on top of the monkey patch and upload the diff here?
It also looks like the version number for the mediaelement script needs to be bumped in script-loader.php
.
#6
@
9 years ago
- Owner set to wonderboymusic
- Status changed from reopened to assigned
I will monkey this
This ticket was mentioned in Slack in #core by eric. View the logs.
9 years ago
Note: See
TracTickets for help on using
tickets.
In 34048: