WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#33798 closed task (blessed) (fixed)

Upgrade MediaElement to 2.18.1

Reported by: wonderboymusic Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: External Libraries Keywords:
Focuses: javascript Cc:

Description

Changelog: https://github.com/johndyer/mediaelement/compare/2.17.0...2.18.1

This might require monkey-patching, which I'll do.

Attachments (2)

4.4.monkey.diff (21.6 KB) - added by wonderboymusic 6 years ago.
33798.diff (156.5 KB) - added by wonderboymusic 6 years ago.

Download all attachments as: .zip

Change History (11)

#1 @wonderboymusic
6 years ago

In 34048:

In [30082], hardcoded heights were removed on the front end for videos rendered via shortcode. These values were not removed from the admin, which was an oversight.

See #33798.

#2 @wonderboymusic
6 years ago

In 34049:

After [34048], restore the else statement for h (height of video) in wp_underscore_video_template().

See #33798.

#3 @wonderboymusic
6 years ago

In 34050:

Upgrade MediaElement to 2.18.1 - monkey-patches to allow H264 in Chromium.

Changelog: https://github.com/johndyer/mediaelement/compare/2.17.0...2.18.1

See #33798.

#4 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#5 @bradyvercher
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

There was a breaking API change in one of the public methods in 2.18 that's throwing errors everywhere I'm using it. I submitted a PR upstream to fix backward compatibility and it got merged a couple days ago.

What's the best way of getting that incorporated here? Can I cherry pick that commit and apply it on top of the monkey patch and upload the diff here?

It also looks like the version number for the mediaelement script needs to be bumped in script-loader.php.

#6 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Status changed from reopened to assigned

I will monkey this

@wonderboymusic
6 years ago

#7 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34339:

MediaElement: apply monkey patch to include a PR which fixes a breaking change made upstream on a public interface:
https://github.com/johndyer/mediaelement/commit/ccba8d0b6ad1661026e43879876126223c88c5e2

Props bradyvercher.
Fixes #33798.

#8 @dd32
6 years ago

In 35713:

Bump the version of MediaElement in script-loader.php to match what we're shipping with.
See #33798
Fixes #34743

This ticket was mentioned in Slack in #core by eric. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.