"Attribute content to" dropdown missing when deleting a user in network admin (multisite)

[figureone]

Changeset [32333] introduced a bug that removed the html select element from the rendered output. The cause is an early closing parenthesis to the _e() function.
https://core.trac.wordpress.org/changeset/32333/trunk/src/wp-admin/network/users.php

Simple fix in attached patch. Screenshots attached to illustrate.
/wp-admin/network/users.php

[figureone]

Screenshot illustrating missing html select element.

[jeremyfelt]

Hi @figureone, thanks for the report and the patch!

I'll alter it slightly as the "Attribute all content to:" does need to be contained in _e() for translation.

[figureone]

Awesome, thanks @jeremyfelt.

[jeremyfelt]

33811.diff closes the translation and outputs the user dropdown on a new line.

I'm going to assign this to 4.3.1 as it breaks a process pretty badly.

[jeremyfelt]

In 34012:

Multisite: Display content attribution drop down when deleting a user

The previous move from echo() to _e() left some of the output hanging. Introduced in [32333].

Props figureone.
Fixes #33811 for trunk.

[jeremyfelt]

Reopening for 4.3.1 consideration

[jeremyfelt]

In 34058:

Multisite: Display content attribution drop down when deleting a user

The previous move from echo() to _e() left some of the output hanging. Introduced in [32333].

Merge of [34057] to the 4.3 branch.

Props figureone.
Fixes #33811.

[jeremyfelt]

Yeah. Merge of [34012] to the 4.3 branch... :)

[figureone]

Sweet. Thanks for the fast turnaround!

[tanguysauvin]

Hi,

This patch creates a bug, the former version was correct:

<?php echo __( 'Attribute all content to:' ) . "</label>\n" . $user_dropdown; ?></li> 

The new version doesn't make sense since _e is a wrapper for echo and enclose only 'Attribute all content to:' and not the end of the statement:

<?php _e( 'Attribute all content to:' ) . "</label>\n" . $user_dropdown; ?></li> 

A really correct version would be (cause commas are a bit faster):

<?php echo __( 'Attribute all content to:' ), "</label>\n", $user_dropdown; ?></li> 

[SergeyBiryukov]

Replying to tanguysauvin:

The new version doesn't make sense since _e is a wrapper for echo and enclose only 'Attribute all content to:' and not the end of the statement:

<?php _e( 'Attribute all content to:' ) . "</label>\n" . $user_dropdown; ?></li> 

This was fixed in [34012].