WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#33813 closed enhancement (fixed)

Move some ad-hoc functions to `wp-admin/includes`

Reported by: wonderboymusic Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Administration Keywords:
Focuses: Cc:

Description

wp-admin/*.php are the handlers/loaders/views/junk drawers of our admin "templating" scheme. wp-admin/inlcludes/*.php contain files that house functions, separated by genre. Some ad hoc functions from the junk drawers should move to these includes.

Change History (14)

#1 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Status changed from new to assigned

#2 @wonderboymusic
6 years ago

In 34017:

Move wp_widgets_access_body_class() (a hook callback) from wp-admin/widgets.php to wp-admin/includes/widgets.php.

See #33813.

#3 @wonderboymusic
6 years ago

In 34018:

Move plugin_sandbox_scrape() from wp-admin/plugins.php to wp-admin/includes/plugin.php.

See #33813.

#4 @wonderboymusic
6 years ago

In 34019:

Move comment_footer_die() from wp-admin/comment.php to wp-admin/includes/comment.php.

See #33813.

#5 @wonderboymusic
6 years ago

In 34020:

Move redirect_post() from wp-admin/post.php to wp-admin/includes/post.php.

See #33813.

#6 @wonderboymusic
6 years ago

In 34021:

Move 2 ad hoc user admin functions:

  • Move use_ssl_preference() from wp-admin/user-edit.php to wp-admin/includes/user.php.
  • Move admin_created_user_email() from wp-admin/user-new.php to wp-admin/includes/user.php.

See #33813.

#7 @wonderboymusic
6 years ago

In 34022:

Move ad hoc Options functions to wp-admin/includes/options.php:

  • Move options_discussion_add_js() from wp-admin/options-discussion.php
  • Move options_general_add_js() from wp-admin/options-general.php
  • Move options_permalink_add_js() from wp-admin/options-permalink.php
  • Move options_reading_add_js() from wp-admin/options-reading.php
  • Move options_reading_blog_charset() from wp-admin/options-reading.php

See #33813.

#8 @wonderboymusic
6 years ago

In 34023:

Create wp-admin/includes/network.php via svn cp and only load it in wp-admin/network.php. Move the functions there.

See #33813.

#9 @wonderboymusic
6 years ago

In 34025:

Move confirm_delete_users() from wp-admin/network/users.php to wp-admin/includes/ms.php.

See #33813.

#10 @wonderboymusic
6 years ago

In 34026:

Move network_settings_add_js() from wp-admin/network/settings.php to wp-admin/includes/ms.php.

See #33813.

#11 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

These files almost look usable now

#12 @wonderboymusic
6 years ago

In 34036:

Move ad hoc functions from wp-admin/credits.php to wp-admin/includes/credits.php, which is only included by the former.

See #33813.

#13 @wonderboymusic
6 years ago

In 34037:

Create a new file, wp-admin/includes/noop.php, which loads all of the noop functions for load-script|styles.php and is only loaded by those files. DRYs in the process.

See #33813.

#14 @wonderboymusic
6 years ago

#21271 was marked as a duplicate.

Note: See TracTickets for help on using tickets.