WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33818 closed defect (bug) (fixed)

#a11y-headings - Add Plugins

Reported by: Cheffheid Owned by: afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: has-patch commit
Focuses: ui, accessibility Cc:

Description

All the plugin names are currently h4s. If they are to be headings at all, they should be h2.

Though, Popular Tags is also a heading on the page, currently at h3. Bumping it up to h2 and having it at the same level as the plugins may make it appear as another plugin and confuse people. Leaving it at h3 makes it a subheading under whatever the last plugin is, which is also weird.

So perhaps we can remove the heading on one or the other (the plugins, or the "Popular Tags" text)?

#a11y-headings

Attachments (2)

33818.patch (1.8 KB) - added by afercia 4 years ago.
33818.2.patch (675 bytes) - added by afercia 4 years ago.
Fix for the missed jQuery selector.

Download all attachments as: .zip

Change History (15)

#1 @afercia
4 years ago

We should also consider the headings we would like to add and we're discussing in #32147 see the screenshot in the comment 11: https://core.trac.wordpress.org/ticket/32147#comment:11
If we're going to add them, I'd say the Plugin names should be a <h3> and the "Popular Tags" bumped up from <h3> to <h2>.

#2 @wonderboymusic
4 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to afercia
  • Status changed from new to assigned

This ticket was mentioned in Slack in #accessibility by cheffheid. View the logs.


4 years ago

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


4 years ago

#5 @afercia
4 years ago

To move on with this ticket we'd really need a feedback about #32147.

Last edited 4 years ago by afercia (previous) (diff)

This ticket was mentioned in Slack in #core by afercia. View the logs.


4 years ago

#7 @afercia
4 years ago

For more details about why we need feedback on #32147 please refer to this comment and screenshot:
https://core.trac.wordpress.org/ticket/33819#comment:8

@afercia
4 years ago

#8 @afercia
4 years ago

  • Focuses ui added
  • Keywords has-patch added

First pass. Any feedback more than welcome, please leave a comment on the ticket if you notice any visual change or potential breakage with the patch applied. In the screenshot below, the new headings hierarchy (for the "featured" view). Notice the hidden headings added with #32147.

https://cldup.com/L1Idx-tO1y.png

#9 @afercia
4 years ago

  • Keywords commit added

#10 @afercia
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35009:

Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy.

Fixes #33818.

#11 @afercia
4 years ago

  • Keywords needs-patch added; has-patch commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

We missed to update this in updates.js:

$( '.plugin-card-' + message.slug ).find( 'h4 a' ).focus();

it's used to move focus back to the plugin title in the plugin card when updating a plugin from the modal dialog. Should be changed in h3 a or maybe in .column-name a.

@afercia
4 years ago

Fix for the missed jQuery selector.

#12 @afercia
4 years ago

  • Keywords has-patch commit added; needs-patch removed

#13 @afercia
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 35155:

Accessibility: update a jQuery selector used for the Plugin Cards after [35009].

When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.

Fixes #33818.

Note: See TracTickets for help on using tickets.