#a11y-headings - Add Plugins

[Cheffheid]

All the plugin names are currently h4s. If they are to be headings at all, they should be h2.

Though, Popular Tags is also a heading on the page, currently at h3. Bumping it up to h2 and having it at the same level as the plugins may make it appear as another plugin and confuse people. Leaving it at h3 makes it a subheading under whatever the last plugin is, which is also weird.

So perhaps we can remove the heading on one or the other (the plugins, or the "Popular Tags" text)?

#a11y-headings

[afercia]

We should also consider the headings we would like to add and we're discussing in #32147 see the screenshot in the comment 11: https://core.trac.wordpress.org/ticket/32147#comment:11
If we're going to add them, I'd say the Plugin names should be a <h3> and the "Popular Tags" bumped up from <h3> to <h2>.

[afercia]

To move on with this ticket we-d really need a feedback about #32147.

[afercia]

For more details about why we need feedback on #32147 please refer to this comment and screenshot:
https://core.trac.wordpress.org/ticket/33819#comment:8

[afercia]

First pass. Any feedback more than welcome, please leave a comment on the ticket if you notice any visual change or potential breakage with the patch applied. In the screenshot below, the new headings hierarchy (for the "featured" view). Notice the hidden headings added with #32147.

[afercia]

In 35009:

Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy.

Fixes #33818.

[afercia]

We missed to update this in updates.js:

$( '.plugin-card-' + message.slug ).find( 'h4 a' ).focus();

it's used to move focus back to the plugin title in the plugin card when updating a plugin from the modal dialog. Should be changed in h3 a or maybe in .column-name a.

[afercia]

Fix for the missed jQuery selector.

[afercia]

In 35155:

Accessibility: update a jQuery selector used for the Plugin Cards after [35009].

When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.

Fixes #33818.