WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#33824 closed defect (bug) (fixed)

Hide bulk actions dropdown when there are no posts

Reported by: swissspidy Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: needs-patch
Focuses: ui, administration Cc:

Description

This is a followup on #21856 and #21015.

The bulk actions dropdown is useless if there aren't any posts in the current view. We should hide it, just like the other dropdowns mentioned in the above tickets.

Attachments (1)

33824.diff (683 bytes) - added by mehulkaklotar 6 years ago.
check for if items or posts are there then display added

Download all attachments as: .zip

Change History (9)

@mehulkaklotar
6 years ago

check for if items or posts are there then display added

#1 @mehulkaklotar
6 years ago

  • Keywords has-patch added; needs-patch removed

#2 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 34076:

List Tables: don't render "extra tablenav" if there are no posts. This includes Bulk Actions, Dates Dropdown, Category Dropdowns, Pagination.

Also ensure that the Months dropdown, when it is shown, shows months from the proper set of posts.

Props egower, CoenJacobs, MikeHansenMe, mehulkaklotar.
Fixes #33824, #21015, #21856.

#3 @ocean90
6 years ago

  • Milestone changed from Awaiting Review to 4.4

#4 @ryan
6 years ago

  • Keywords needs-screenshots added

#5 @ocean90
6 years ago

  • Keywords needs-patch added; has-patch needs-screenshots removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

[34076] includes an UX issue for comments and maybe other screens with extra filters

  1. Go to wp-admin/edit-comments.php
  2. Make sure you have no trackbacks in your list
  3. Filter by pings
  4. You will get the "No comments found." view without any filters
  5. Now click on the "All" link (wp-admin/edit-comments.php?comment_type=pings&comment_status=all)
  6. Because it includes the filter you are at step 4 again

#7 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 34707:

List Tables: only hide bulk actions when there are no items, don't hide all of the extra table nav.

Fixes #33824.

#8 @kitchin
6 years ago

For future reference, see also https://core.trac.wordpress.org/attachment/ticket/29789/29789.fix2.diff in #29789. We could disable the bulk drop-down selects in js instead of html. I don't know how we handle it when the table loads dynamically, but in that case the solution is js anyway, so might as well make it easy.

Note: See TracTickets for help on using tickets.