WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33856 closed defect (bug) (fixed)

Incomplete documentation for `get_query_var()`

Reported by: swissspidy's profile swissspidy Owned by: drewapicture's profile DrewAPicture
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.9
Component: Query Keywords: has-patch
Focuses: docs Cc:

Description

Since WordPress 3.9, the get_query_var() function (and therefore WP_Query::get()) accepts an optional $default parameter.

This change, however, is not documented in the docblock, which just caused me some debugging pain.

Attachments (1)

33856.diff​ (1.1 KB) - added by swissspidy 9 years ago.

Download all attachments as: .zip

Change History (5)

@swissspidy
9 years ago

#1 @swissspidy
9 years ago

  • Component changed from General to Query
  • Milestone changed from Awaiting Review to 4.4

This ticket was mentioned in ​Slack in #core by swissspidy. ​View the logs.
9 years ago

#3 @DrewAPicture
9 years ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing

#4 @DrewAPicture
9 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 34284:

Docs: Add documentation to get_query_var() and WP_Query::get() for the optional $default argument, introduced in 3.9 in [27304].

Props swissspidy.
Fixes #33856.

Note: See TracTickets for help on using tickets.