Context Navigation

← Previous Ticket
Next Ticket →

#33877 closed enhancement (fixed)

Initialise $_SERVER[ 'REMOTE_ADDR' ] in the unit test bootstrap

Reported by:	johnbillion	Owned by:	johnbillion
Priority:	normal	Milestone:	4.4
Component:	Build/Test Tools	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

In various tests, $_SERVER[ 'REMOTE_ADDR' ] is given a value in order to prevent PHP notices being triggered by functions such as wpmu_log_new_registrations() which use the superglobal without validating it first.

$_SERVER[ 'REMOTE_ADDR' ] should be initialised with a dummy value in the unit test bootstrap so individual tests don't need to.

I had this patch applied while running the tests for #25162, which is why the failures were missed.

Attachments (1)

33877.patch (6.4 KB ) - added by johnbillion 11 years ago.

Download all attachments as: .zip

Change History (5)

@johnbillion
11 years ago

Attachment 33877.patch added

#1 @johnbillion
11 years ago

Keywords has-patch added

#2 @johnbillion
11 years ago

Owner set to johnbillion
Resolution → fixed
Status new → closed

In 34172:

Initialise $_SERVER[ 'REMOTE_ADDR' ] during the test bootstrap so individual tests need not.

Fixes #33877
Fixes #25162

#3 @johnbillion
11 years ago

In 34173:

Missed files from [34172].

See #33877

#4 @johnbillion
11 years ago

In 34518:

Another missed file from [34172].

See #33877

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core