WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#33894 closed defect (bug) (fixed)

its != it's (again)

Reported by: kitchin Owned by: DrewAPicture
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: General Keywords:
Focuses: docs Cc:

Description

This is a follow-up to #22665. Doc fix only, for grammar/usage. More of the same issue as 22665, which was fixed and closed in 3.6.

Here is a patch for the following files. I can excise upstreams. Which ones should I take out?

src/wp-admin/includes/file.php
src/wp-admin/includes/image-edit.php
src/wp-includes/class-json.php
src/wp-includes/class-pop3.php
src/wp-includes/class-wp-http-streams.php
src/wp-includes/ID3/module.tag.id3v2.php
src/wp-includes/js/tinymce/tiny_mce_popup.js
src/wp-includes/js/tinymce/tinymce.js
src/wp-includes/SimplePie/Cache/Memcache.php
src/wp-includes/SimplePie/Item.php
src/wp-includes/wp-db.php
tests/phpunit/data/formatting/sizzle.js
tests/phpunit/tests/canonical.php
tests/phpunit/tests/mail.php
tests/qunit/editor/js/qunit/qunit.js
tests/qunit/editor/tinymce/dom/DomQuery.js

Attachments (2)

33894.diff (26.9 KB) - added by kitchin 5 years ago.
Mostly replacing "it's" with "its" in the right places.
33894.2.diff (6.6 KB) - added by kitchin 5 years ago.
same patch, excluding upstreams

Download all attachments as: .zip

Change History (5)

@kitchin
5 years ago

Mostly replacing "it's" with "its" in the right places.

#1 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.4

#2 @SergeyBiryukov
5 years ago

These ones can be patched:

src/wp-admin/includes/file.php
src/wp-admin/includes/image-edit.php
src/wp-includes/class-json.php
src/wp-includes/class-pop3.php
src/wp-includes/class-wp-http-streams.php
src/wp-includes/wp-db.php
tests/phpunit/tests/canonical.php
tests/phpunit/tests/mail.php

These ones should be taken upstream:

src/wp-includes/ID3/module.tag.id3v2.php
src/wp-includes/js/tinymce/tiny_mce_popup.js
src/wp-includes/js/tinymce/tinymce.js
src/wp-includes/SimplePie/Cache/Memcache.php
src/wp-includes/SimplePie/Item.php
tests/phpunit/data/formatting/sizzle.js
tests/qunit/editor/js/qunit/qunit.js
tests/qunit/editor/tinymce/dom/DomQuery.js

@kitchin
5 years ago

same patch, excluding upstreams

#3 @DrewAPicture
5 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 34234:

Docs: Put "it's" in its place (again).

Props kitchin.
Fixes #33894.

Note: See TracTickets for help on using tickets.