Hide/ Show password button not working after clicking cancel

[umesh.nevase]

I've found bug on User profile page and New user page after updating wordpress to 4.3.1. I've tried to explain the scenario below.

When user clicks on Generate password button then Password field,'Hide/Show' toggle button and 'Cancel' button get visible and 'Hide/Show' toggle button shows 'Hide' text.

After that, click on 'Hide' button, then password field hides the password text and 'Hide/Show' toggle button get set to 'Show'.

After that, click on cancel button, All the fields get hide. till these steps all is working fine.

But when user again click 'Generate password' button, all the above elements get visible, the password field shows text password visible but the 'Hide/Show' toggle button display as 'Show' button instead of 'Hide' button. Also the When user clicks 'Password' and 'New password' lable, the password text field not get focused. it looses focus when user cancel button.

I've attached screenshot for the issue.

[umesh.nevase]

I've attached screenshot for issue coming after the steps explained in scenario

[umesh.nevase]

I've added patch to fix the issue

[umesh.nevase]

reset the "Hide/Show" toggle button after clicking cancel.

[umesh.nevase]

I've added 2 patch files 33897.diff​ for reset the toggle button after clicking 'Generate password' button and 33897.1.diff​ for reset the toggle button after clicking 'Cancel' button

[adamsilverstein]

@umesh.nevase: Thanks for the bug report and the patches.

I was able to reproduce the bug following the steps you outlined. I haven't yet had a chance to test your fix. Looking at the code, I wonder if we may be able to apply the existing toggle logic for the show/hide button?

[umesh.nevase]

Replying to adamsilverstein: I've checked by existing toggle logic but, it was not worked. So I've added these line fore reset the buttons text.

[wonderboymusic]

In 34539:

Profile: when clicking "Generate Password", toggling visibility, then canceling, ensure that the UI resets properly for when the "Generate Password" button is clicked again.

Props umesh.nevase.
Fixes #33897.