WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #33900, comment 12


Ignore:
Timestamp:
06/06/2016 08:40:43 PM (3 years ago)
Author:
flixos90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33900, comment 12

    initial v1  
    77
    88I wonder whether the instance check is really necessary (edge-case). We can probably do it since it shouldn't cause issues, but we don't do a check like this in other areas of Core (see the change in `get_main_network_id()` in this patch for example). I wonder whether this is worth changing in this function - I'm not opposed to it, it's just different from how we handle `$current_site` in the rest of Core (always assume it's a `WP_Network`).
     9
     10Btw sorry about the weird spacing changes in `wp-includes/load.php`, not sure what my editor did there.