WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33908 closed defect (bug) (fixed)

Fix reset password generator

Reported by: ldinclaux Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: Login and Registration Keywords:
Focuses: Cc:
PR Number:

Description

This is a follow up of #33892.

The class "user-pass1-wrap" exists on purpose. So the attached patch adds a wrapper with the "user-pass1-wrap" class in the reset password form.

Doing this leveraged a bug in wp-admin/js/user-profile.js that is hiding the "user-pass1-wrap" div on purpose: its visibility has to be toggled by the "Generate" button.

But, because that button doesn't exists in the reset password form, the password fields stay hidden.

In short, all this was working properly only because there was a semantic error in the reset password form...

The attached patch fixes it all.

Attachments (1)

password_gen_fix.diff (2.2 KB) - added by ldinclaux 4 years ago.
Fix

Download all attachments as: .zip

Change History (3)

@ldinclaux
4 years ago

Fix

#1 @SergeyBiryukov
4 years ago

  • Component changed from General to Login and Registration
  • Milestone changed from Awaiting Review to 4.4

#2 @wonderboymusic
4 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 34371:

Passwords: fix the markup on the Reset Password Form for user-pass1 so the JavaScript operates properly.

Props ldinclaux.
See #33892.
Fixes #33908.

Note: See TracTickets for help on using tickets.