WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#33923 closed defect (bug) (fixed)

Post Lists Table: 'All' view not selected for paged responses

Reported by: kraftbj Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.2
Component: Posts, Post Types Keywords: has-patch
Focuses: administration Cc:

Description (last modified by pento)

In [31828] ( see: #24869 ), a new is_base_request function is added to class-wp-posts-lists-table.php to indicate if the "All" view should have the current class associated with it, intentionally not including it when the view is filtered (by counting the $_GET array).

This should still select "All" when paging through that view.

Steps to reproduce:
Visit the Posts list (Posts->All Posts) and page to a second page.

Expected: "All" to still have the current class and reflect the applicable styling.

Actual: No "current" defined.

Least churn would be to unset $_GET['paged']. AFAIK, unset only impacts the local instance of a global, so we should be able to do that in one line without impacting anything else.

Attachments (2)

33923.diff (544 bytes) - added by kraftbj 4 years ago.
33923.2.diff (924 bytes) - added by wonderboymusic 4 years ago.

Download all attachments as: .zip

Change History (7)

@kraftbj
4 years ago

#1 @kraftbj
4 years ago

  • Keywords has-patch added

#2 @pento
4 years ago

  • Description modified (diff)

#3 @wonderboymusic
4 years ago

  • Milestone changed from Awaiting Review to 4.4

33923.2.diff doesn't modify the superglobal

#4 @wonderboymusic
4 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 34331:

Post List Table: 'All' view should be selected when appropriate for paged responses.

Props kraftbj, wonderboymusic.
Fixes #33923.

This ticket was mentioned in Slack in #core by ronaldhuereca. View the logs.


3 years ago

Note: See TracTickets for help on using tickets.