Opened 9 years ago
Closed 9 years ago
#33925 closed defect (bug) (fixed)
same SLUGS make problems in dashboard SCREEN OPTIONS
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Administration | Keywords: | needs-patch |
Focuses: | Cc: |
Description
hi.
I register taxonomy (with name "laptop") and custom post-type, with the same name.
but in APPEARENCE>CUSTOM MENUS , in "SCREEN OPTIONS",only taxonomies checkoxes are shown... there should be checkboxes for CUSTOM POST TYPES too.
Attachments (3)
Change History (12)
#3
@
9 years ago
- Keywords has-patch added; needs-patch removed
The problem is caused by an id conflict. The solution would be to add "taxonomy-" prefix for taxonomies in wp_nav_menu_taxonomy_meta_boxes(); in wp-admin/includes/nav-menu.php. I've tested it and it seems it doesn't cause any side effects.
#4
@
9 years ago
Seems like a straight forward fix. We should be aware that it will initially show all taxonomy meta boxes again, since user settings will not apply to them anymore until they're updated.
#5
@
9 years ago
- Owner set to helen
- Status changed from new to reviewing
@helen would like your input here, por favor
#6
@
9 years ago
Losing the user settings for hiding taxonomies is a little annoying. Seems like it would be better to affect post types, since those are more likely to be desired as menu items and so showing them again might be less fallout? Unsure. Thoughts welcome.
#8
@
9 years ago
- Keywords needs-patch added; has-patch removed
- Resolution fixed deleted
- Status changed from closed to reopened
Looks like this broke wp_initial_nav_menu_meta_boxes()
.
33925.2.diff fixes the $initial_meta_boxes
array by replacing add-page
and add-post
with add-post-type-page
and add-post-type-post
, respectively.
I remember having some issues with a CPT and a taxonomy with the same name as well.