Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #33932, comment 5


Ignore:
Timestamp:
09/20/2015 08:51:29 AM (10 years ago)
Author:
johnbillion
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33932, comment 5

    initial v1  
    44
    55 * If the filter returns false for one or more of the update types, it prevents the email from being sent for all subsequent update types too. The `return` statement after the filter should probably be a `continue`. Then below the `foreach` loop you could `return` if the `$body` variable is empty.
    6  * The diff should be generated from either the root of your repo so other people can apply the patch without having to specify which file is to be patched.
     6 * The diff should be generated from the root of your repo so other people can apply the patch without having to specify which file is to be patched.
    77 * There's a typo in the docblock: `translators` instead of `translations`.
    88 * Passing `$this` as the third parameter to the filter would be a good idea so the filter receives as much context as possible.