Changes between Initial Version and Version 1 of Ticket #33932, comment 5
- Timestamp:
- 09/20/2015 08:51:29 AM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #33932, comment 5
initial v1 4 4 5 5 * If the filter returns false for one or more of the update types, it prevents the email from being sent for all subsequent update types too. The `return` statement after the filter should probably be a `continue`. Then below the `foreach` loop you could `return` if the `$body` variable is empty. 6 * The diff should be generated from eitherthe root of your repo so other people can apply the patch without having to specify which file is to be patched.6 * The diff should be generated from the root of your repo so other people can apply the patch without having to specify which file is to be patched. 7 7 * There's a typo in the docblock: `translators` instead of `translations`. 8 8 * Passing `$this` as the third parameter to the filter would be a good idea so the filter receives as much context as possible.