Taxonomies with show_ui set to false should not be accessible via the admin area

[johnbillion]

Same as #33763 for taxonomies.

If a taxonomy is registered with show_ui set to false, it's still possible to access the term editing screen for the taxonomy by manually navigating to the correct URL.

[johnbillion]

In 34359:

Remove the ability to view the term editing screen for taxonomies with show_ui set to false. It is unexpected and unintended behaviour that this is allowed.

If your plugin or site does rely on this behaviour, the arguments that are passed to register_taxonomy() should be altered so that show_ui is true, and arguments such as show_in_menu and show_in_nav_menus are false.

Fixes #33938

[danielbachhuber]

We're hiding UI to add our own custom metabox (combining multiple taxonomies) and admin menu. However, register_taxonomy() doesn't offer a registration argument to disable core meta boxes. It would be nice to have the argument, so we don't have to deregister metaboxes.

[helen]

Replying to danielbachhuber:

We're hiding UI to add our own custom metabox (combining multiple taxonomies) and admin menu. However, register_taxonomy() doesn't offer a registration argument to disable core meta boxes. It would be nice to have the argument, so we don't have to deregister metaboxes.

register_taxonomy() has a meta_box_cb arg, which can be set to false.

[danielbachhuber]

Replying to helen:

Replying to danielbachhuber:

We're hiding UI to add our own custom metabox (combining multiple taxonomies) and admin menu. However, register_taxonomy() doesn't offer a registration argument to disable core meta boxes. It would be nice to have the argument, so we don't have to deregister metaboxes.

register_taxonomy() has a meta_box_cb arg, which can be set to false.

Ah. I tried __return_false, but ended up with an empty meta box. Explicitly setting to false does the trick.

[johnbillion]

Suffers from the same problem as #33763.

[johnbillion]

In 35704:

Move the show_ui logic into the get_edit_post_link() and get_edit_term_link() functions to facilitate post types and terms which specify show_ui as false but provide a custom editing UI via the get_edit_post_link and get_edit_term_link filters.

Fixes #33763
Fixes #33938