Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#33939 closed defect (bug) (fixed)

Duplicate strings: Press return or enter

Reported by: pavelevap Owned by: SergeyBiryukov
Priority: normal Milestone: 4.4
Component: I18N Version: 4.4
Severity: normal Keywords: needs-patch
Cc: Focuses:

Description

We have 3 strings, but they are used for similar purpose (screen readers info for opening panels). Could we merge them? Which is the best?

Press return or enter to open this panel

Press return or enter to expand

Press return or enter to open

Change History (3)

#1 @SergeyBiryukov
11 years ago

  • Keywords needs-patch added
  • Milestone Awaiting Review → 4.4

The former one is used for Customizer panels, and the latter two are used or sections.

I think we could at least reduce them to two strings:

  • "Press return or enter to open this panel" for panels.
  • "Press return or enter to open this section" for sections.

Thoughts?

#2 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 35232:

Merge two strings for expanding accordion and Customizer sections.

Props pavelevap.
Fixes #33939.

#3 @pavelevap
11 years ago

Thank you, Sergey! You are right, two specific strings are probably better for context for screen readers.

Note: See TracTickets for help on using tickets.