WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#33939 closed defect (bug) (fixed)

Duplicate strings: Press return or enter

Reported by: pavelevap Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: I18N Keywords: needs-patch
Focuses: Cc:

Description

We have 3 strings, but they are used for similar purpose (screen readers info for opening panels). Could we merge them? Which is the best?

Press return or enter to open this panel

Press return or enter to expand

Press return or enter to open

Change History (3)

#1 @SergeyBiryukov
4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.4

The former one is used for Customizer panels, and the latter two are used or sections.

I think we could at least reduce them to two strings:

  • "Press return or enter to open this panel" for panels.
  • "Press return or enter to open this section" for sections.

Thoughts?

#2 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 35232:

Merge two strings for expanding accordion and Customizer sections.

Props pavelevap.
Fixes #33939.

#3 @pavelevap
4 years ago

Thank you, Sergey! You are right, two specific strings are probably better for context for screen readers.

Note: See TracTickets for help on using tickets.