Possible bug in update_option()

[roscohead]

I posted this on the forum, and someone kindly pointed me here :)

I think I've hit a bug in the update_option() function. The problem occurs when the $newvalue is an array containing arrays - it checks

	// If the new and old values are the same, no need to update.
	$oldvalue = get_option($option_name);
	if ( $newvalue == $oldvalue ) {
		return false;
	}

to see if the value has changed. However this behaves incorrectly when the only change is in the order of elements of the sub-array, the comparison returns true, so the setting is never updated.

My workaround is to do a comparison on the serialized versions instead:

	// If the new and old values are the same, no need to update.
	$oldvalue = get_option($option_name);
	if ( maybe_serialize($newvalue) == maybe_serialize($oldvalue) ) {
		return false;
	}

This seems to work, and doesn't seem to break anything, but it has only been minimally tested. If there's a better way to fix the problem, feel free to ignore my suggested fix :)

ROSCO

[Viper007Bond]

What about a triple equal sign (===) instead. Wouldn't that work?

[roscohead]

D'oh! Of course it would! Thanks for that.

[markjaquith]

Patch it up!

[ryan]

(In [4920]) Use === to compare option values. Props roscohead and Viper007Bond. fixes #3394

[markjaquith]

Backport candidate for 2.1.2 and 2.0.10 ?