Opened 11 years ago
Last modified 37 hours ago
#33940 assigned defect (bug)
Double spaces in term names can cause problems
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Review | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | XML-RPC | Keywords: | needs-patch |
| Focuses: | Cc: |
Description
Create a tag called 'test term'.
Use XML-RPC to create a post with a tag of:
test term
(two spaces). You'll get an error thrown, with the post not created:
A term with the name already exists in this taxonomy
This appears to be due to the _insert_post function in XML-RPC using get_term_by( 'name', $term_name, $taxonomy );, which is returning false - thus it tries to create the term as new, and fails.
Most other aspects of WP seem to filter the term name to strip double spaces first - is that what is necessary here? Or could the issue affect more than just XML-RPC?
Change History (7)
#5
@
7 years ago
- Owner boonebgorges deleted
No :) I'd be happy to review a patch if someone wants to dig into the root cause.
#6
@
7 years ago
Hey there,
To make creating a patch easier it’d be good to have a unit test showing the problem.This test file tests/phpunit/tests/xmlrpc/wp/newPost.php has examples of creating posts with terms.
#7
@
37 hours ago
Tested on WordPress 7.1-alpha-62161-src — this bug no longer reproduces.
Reproduction steps taken:
- Created a
post_tagtermtest term(single space) viawp_insert_term() - Loaded all IXR dependencies via
glob( ABSPATH . 'wp-includes/IXR/class-IXR-*.php' ) - Instantiated
wp_xmlrpc_serverdirectly - Called
wp_newPost()withterms_names => [ 'post_tag' => ['test term'] ](double space)
Post was created successfully with a post ID returned — no A term with the name already exists error thrown.
@boonebgorges Do you have any interest in working this one?