Help tabs rendering in wrong order

[lilaeamedia]

Tabs are no longer rendering in the order $screen->add_help_tab() is called.

It appears to be random, like keys from an associative array.

Is there a new sort order parameter?

(4.4-alpha-34360)

[DrewAPicture]

Replying to lilaeamedia:

Tabs are no longer rendering in the order $screen->add_help_tab() is called.

It appears to be random, like keys from an associative array.

Is there a new sort order parameter?

Yes, a priority system was introduced in [33985] for 4.4.

[helen]

Can we take at least a few minutes to see what we can do about compat (stable sort, I guess)? Might not be worth it, but we should consciously decide that.

Who thought we'd ever miss something about PHP 4? :)

[wonderboymusic]

In 34370:

Help Tabs: when returning help tabs, return them in order of priority, but also return the items in each priority in the order that they were added.

Fixes #33941.

[jorbin]

In 36089:

Help Tab Order should be based on the Priority Argument

[34370] made the order that tabs are returned respect the order they are added, however it broke the respect of priority. By using a ksort instead of a sort, we can restore that default behavior. This adjusts the unit tests so that both order added and priority are tested.

Props meitar, swissspidy, jorbin
Fixes #35215. See #33941.

[dd32]

In 36104:

Help Tab Order should be based on the Priority Argument

[34370] made the order that tabs are returned respect the order they are added, however it broke the respect of priority. By using a ksort instead of a sort, we can restore that default behavior. This adjusts the unit tests so that both order added and priority are tested.

Merges [36089] to the 4.4 branch.
Props meitar, swissspidy, jorbin
Fixes #35215. See #33941.