WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#33973 closed defect (bug) (fixed)

Network subsite title is limited/cut to 50 characters

Reported by: theode Owned by: chriscct7
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.0
Component: Networks and Sites Keywords: has-patch commit
Focuses: multisite Cc:

Description (last modified by chriscct7)

In wpmu_validate_blog_signup of ms-functions.php I can find near Line 600

$blog_title = substr( $blog_title, 0, 50 );

Is there a reason for this?

Attachments (1)

33973.patch (446 bytes) - added by chriscct7 5 years ago.

Download all attachments as: .zip

Change History (9)

#1 @chriscct7
5 years ago

  • Description modified (diff)

#2 @chriscct7
5 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.4
  • Owner set to chriscct7
  • Status changed from new to assigned
  • Version changed from 4.3.1 to 3.0

I did a git blame on the line in question and it's one of the original, unaltered lines from the WPMU merge, so it was originally a restriction in WPMU. Currently in WordPress the title of a blog is stored in a column whose size is LONGTEXT, so there doesn't appear to be a need for the restriction at least from a storage standpoint.

Unless someone has a reason for wanting the limit to remain, when a single site install of WordPress can have a title > 50 characters as is, I'll write a patch to remove this for 4.4.

#3 @chriscct7
5 years ago

  • Summary changed from The Blog Title is restricted to 50 signs? to Network subsite title is limited/cut to 50 characters

@chriscct7
5 years ago

#4 @chriscct7
5 years ago

  • Keywords has-patch commit added; needs-patch removed
  • Status changed from assigned to accepted

#5 @chriscct7
5 years ago

Thanks again for the report @theode!

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


5 years ago

#7 @boonebgorges
5 years ago

Source in MU is https://mu.trac.wordpress.org/changeset/1140. Not much explanation there :/

I don't see a problem making the change. Thanks for the ticket and for the patch.

#8 @boonebgorges
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 34455:

Multisite: Don't limit site titles to 50 chars.

This restriction dates from ye olden times, ie https://mu.trac.wordpress.org/changeset/1140.
It is no longer relevant.

Props chriscct7, theode.
Fixes #33973.

Note: See TracTickets for help on using tickets.