WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 18 of Ticket #33999


Ignore:
Timestamp:
07/25/2016 02:46:41 PM (9 years ago)
Author:
ocean90
Comment:

@neogeneva gave the answer for this issue in ticket:36965:6. I could reproduce this behaviour. Results of a few dirname() examples:

Windows *nix
DIRECTORY_SEPARATOR "\" "/"
dirname( '' ) "" ""
dirname( '/' ) "\" "/"
dirname( 'file.php' ) "." "."
dirname( '/.maintenance' ) "\" "/"
dirname( 'foo/.maintenance' ) "foo" "foo"
dirname( '/foo/.maintenance' ) "/foo" "/foo"

33999.patch​ adds a check for a backslash.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #33999

    • Property Status changed from new to reopened
    • Property Summary changed from Wordpress Update issu to WordPress Update issue
    • Property Owner set to SergeyBiryukov
    • Property Version changed from 4.3.1 to 4.2.2
    • Property Milestone changed from Awaiting Review to 4.6
    • Property Keywords has-patch added

  • Ticket #33999 – Description

    initial v18  
    33You need to modify the ligne 149 in the file wp-admin/includes/file.php
    44
     5{{{
    56if ( empty( $filename ) || '.' == $filename || '/' === $filename ) {
     7}}}
    68
    79replace with
    810
     11{{{
    912if ( empty( $filename ) || '.' == $filename || DIRECTORY_SEPARATOR === $filename ) {
     13}}}
    1014
    1115In windows you need to do that to the upgrade work.