Opened 18 years ago
Closed 17 years ago
#3401 closed defect (bug) (fixed)
raquo should receive gettext treatment
Reported by: | ryan | Owned by: | rob1n |
---|---|---|---|
Milestone: | 2.3 | Priority: | normal |
Severity: | normal | Version: | 2.1 |
Component: | Administration | Keywords: | |
Focuses: | Cc: |
Description
This:
__('Do it »');
not this:
__('Do it') . '»'
Attachments (2)
Change History (17)
#4
@
17 years ago
Is this still a matter now? I haven't come across any separated »'s in the code.
#5
@
17 years ago
Here is a list of files, in which I found right quotes outside i18n-ed strings:
wp-admin/admin-functions.php wp-admin/link-manager.php wp-admin/post-new.php wp-admin/options-permalink.php wp-admin/index.php wp-admin/upload.php wp-admin/custom-header.php wp-admin/page-new.php wp-admin/upload-functions.php wp-admin/index-extra.php wp-content/plugins/akismet/akismet.php
#6
@
17 years ago
- Cc nbachiyski added
- Owner changed from anonymous to rob1n
Those are the ones I could find. Some I had to do <?php _e( '»' ); ?>
, but it shouldn't be any problem to translate.
Look good?
#7
@
17 years ago
Okay, new patch. Those lone »s should be taken care of now.
As for the ones on options-permalinks.php, should the whole thing be translated?
#10
@
17 years ago
We should i18n them with a proper description (using _c
). I will try to do it tomorrow, when I wake up (1:42 AM here now).
P.S. cc-ing to me by username never worked, I don't know why. When you enter the whole email then it works. Strange one...
P.P.S. Nice patch. Thanks for the time spent :-)
#11
@
17 years ago
Here is a sample. If someone can think of better description, it will be gladly accepted :-)
I think some langauges actually use this to switch it to «, such as Arabic, since it's right-to-left, so it reverses the ».