Make WordPress Core

Opened 17 years ago

Closed 17 years ago

#3401 closed defect (bug) (fixed)

raquo should receive gettext treatment

Reported by: ryan's profile ryan Owned by: rob1n's profile rob1n
Milestone: 2.3 Priority: normal
Severity: normal Version: 2.1
Component: Administration Keywords:
Focuses: Cc:

Description

This:

__('Do it »');

not this:

__('Do it') . '»'

Attachments (2)

3401.diff (8.6 KB) - added by rob1n 17 years ago.
bullet-raquos.diff (1.7 KB) - added by nbachiyski 17 years ago.

Download all attachments as: .zip

Change History (17)

#1 @shorty114
17 years ago

I think some langauges actually use this to switch it to «, such as Arabic, since it's right-to-left, so it reverses the ».

#2 @matt
17 years ago

  • Milestone changed from 2.1 to 2.2

#3 @foolswisdom
17 years ago

  • Milestone changed from 2.2 to 2.3

#4 @rob1n
17 years ago

Is this still a matter now? I haven't come across any separated »'s in the code.

#5 @nbachiyski
17 years ago

Here is a list of files, in which I found right quotes outside i18n-ed strings:

wp-admin/admin-functions.php
wp-admin/link-manager.php
wp-admin/post-new.php
wp-admin/options-permalink.php
wp-admin/index.php
wp-admin/upload.php
wp-admin/custom-header.php
wp-admin/page-new.php
wp-admin/upload-functions.php
wp-admin/index-extra.php
wp-content/plugins/akismet/akismet.php

#6 @rob1n
17 years ago

  • Cc nbachiyski added
  • Owner changed from anonymous to rob1n

Those are the ones I could find. Some I had to do <?php _e( '&raquo;' ); ?>, but it shouldn't be any problem to translate.

Look good?

@rob1n
17 years ago

#7 @rob1n
17 years ago

Okay, new patch. Those lone &raquo;s should be taken care of now.

As for the ones on options-permalinks.php, should the whole thing be translated?

#8 @rob1n
17 years ago

(In [5676]) Translate &raquo;. see #3401

#9 @rob1n
17 years ago

Okay, that was everything but the permalink stuff. What to do about that?

#10 @nbachiyski
17 years ago

We should i18n them with a proper description (using _c). I will try to do it tomorrow, when I wake up (1:42 AM here now).

P.S. cc-ing to me by username never worked, I don't know why. When you enter the whole email then it works. Strange one...

P.P.S. Nice patch. Thanks for the time spent :-)

#11 @nbachiyski
17 years ago

Here is a sample. If someone can think of better description, it will be gladly accepted :-)

#12 @rob1n
17 years ago

Maybe something more related to the permalinks?

#13 @nbachiyski
17 years ago

The use in this context has nothing to do with permalinks. Will the fact that the string is used around permalinks settings affect the way a translator will translate it?

#14 @rob1n
17 years ago

Ah, true.

#15 @rob1n
17 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5696]) Translate the rest of the &raquo;'s. Props nbachiyski. fixes #3401

Note: See TracTickets for help on using tickets.